Fixes medical grippers not being usable in surgery

[Migratingcocofruit]

What Does This PR Do

fixes #24594
Adds a missing check for grippers when attempting surgery steps with more than one option.

Why It's Good For The Game

fixes stuff

Images of changes

Testing

Spawned human, dragged it over a bunch of shrapnel and removed them via surgery as a medborg.
Implanted an IV bag in the human. Then and pulled it out as a borg.

Changelog

🆑
fix: Medical grabber now works in surgery
/:cl:

[Sirryan2002]

Putting a hold on this PR. This is not the way to fix this issue... yes technically... this makes medical grippers work and doesn't break other things. However, this is snowflaking a type check into a very nicely written surgery system.

The problem is that the gripper is considered the tool here instead of just being treated as a standard hand like it would be for carbon surgeons. What needs to happen is that a tool should not be passed here (i.g. the gripper) and some procs like put_into_hand() should be refactored for silicons to be able to accept shrapnel.

[Sirryan2002]

@lewcc I would definitely like your two sense here

[Migratingcocofruit]

Putting a hold on this PR. This is not the way to fix this issue... yes technically... this makes medical grippers work and doesn't break other things. However, this is snowflaking a type check into a very nicely written surgery system.

The problem is that the gripper is considered the tool here instead of just being treated as a standard hand like it would be for carbon surgeons. What needs to happen is that a tool should not be passed here (i.g. the gripper) and some procs like put_into_hand() should be refactored for silicons to be able to accept shrapnel.

This check existed already for normal surgery steps, but was missing from proxy surgery steps specifically. I do agree, however.

As things stand the tool used in surgery is given from get_active_hand(), which is used everywhere. If a gripper returns null like a hand would that would break a lot of code.
Maybe have a typecache of all things considered a hand for the purpose of surgery, then set tool to null if it's one of those?
It's still not very pretty and only covers surgery, but at least it condenses everything to one check against a list.

[lewcc]

Given that this is the Specialized Surgery tool, and we really only want to scope its behavior to surgery so it doesn't do more hand-like things than it should, I don't think we should really bring this further up the chain. In principle, I mostly agree with this change.

I'd suggest adding a roundstart trait to the gripper which gets checked here, something like TRAIT_SURGICAL_OPEN_HAND, instead of just checking the raw typepath.

[Fordoxia]

Remember also that the Universal Gripper exists, and should also be capable of performing surgery.

[Migratingcocofruit]

Given that this is the Specialized Surgery tool, and we really only want to scope its behavior to surgery so it doesn't do more hand-like things than it should, I don't think we should really bring this further up the chain. In principle, I mostly agree with this change.

I'd suggest adding a roundstart trait to the gripper which gets checked here, something like TRAIT_SURGICAL_OPEN_HAND, instead of just checking the raw typepath.

Added the traits and tested again; it works. Could you have a look at the code just to make sure it's up to standard?

[BAGELMENSK]

If you can make it so that the Mediborg can pick up organs for surgery, that'd really complete the experience. Engiborg already has their part gripper so its not without precedent.

[Fordoxia]

If you can make it so that the Mediborg can pick up organs for surgery, that'd really complete the experience. Engiborg already has their part gripper so its not without precedent.

Feature freeze.

Also outside of that, design doesn't like the idea of mediborgs being able to grab organs.