refactor: Moves simplemob atmos and temperature requirements to DCS elements.

[warriorstar-orion]

What Does This PR Do

This PR moves code for atmospherics and temperature changes for simplemobs to elements. As a refresher, elements are like components except every element is a singleton that the objects it's attached to shares. Bespoke elements allow for variance in initial arguments, making singletons for every unique set of arguments.

Why It's Good For The Game

This is part of the piecemeal port of TG's basic mobs. It decouples the logic of homeostasis from the basic mob implementation itself, making the mob implementation smaller. In our case, since we don't have basic mobs yet, I've used it to backwards refactor simplemobs as well. This allows us to make sure the code works before the rest of the port.

Images of changes

Examples of the same element being used by multiple mobs for each element type

Testing

In progress.

• Verified in VV that mobs are being grouped by element per atmos/breathing requirements
• Tested spiders like Araneus took atmos damage from being in a pure plasma environment
• Tested corgis die in space
• Tested space bats don't die in space
• Test slimes and cold weakness / fire affinity

Changelog

NPFC

[BiancaWilkson]

Slimes and their cold weakness and fire affinity should probably be tested. I can see that possibly causing some weirdness.

[warriorstar-orion]

Slimes and their cold weakness and fire affinity should probably be tested. I can see that possibly causing some weirdness.

Looks good:

[lewcc]

Little nits, code generally looks good.

[Sirryan2002]

just add the comments lewcc wanted

[warriorstar-orion]

just add the comments lewcc wanted

Ahh this conflicts with a bit of the MILLA changes. I'll look into it.

[lewcc]

LGTM, pending TM

[SteelSlayer]

This was TM'd for a round and this was runtime was happening quite a lot. Pulling the TM for now.

[2024-07-11T04:25:57] Runtime in code/controllers/subsystem/processing/SSdcs.dm:38: list index out of bounds
   proc name: GetIdFromArguments (/datum/controller/subsystem/processing/dcs/proc/GetIdFromArguments)
   src: Datum Component System (/datum/controller/subsystem/processing/dcs)
   call stack:
   Datum Component System (/datum/controller/subsystem/processing/dcs): GetIdFromArguments
   Datum Component System (/datum/controller/subsystem/processing/dcs): GetElement
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): _RemoveElement
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): remove_atmos_requirements
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): Destroy
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): Destroy
   qdel(Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged), 0)
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): death
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): death
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): update_stat
   ...
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): adjustBruteLoss
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): apply_damage
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): bullet_act
   Pirate Gunner (/mob/living/simple_animal/hostile/pirate/ranged): bullet_act
   the kinetic force (/obj/item/projectile/kinetic): Bump
   the kinetic force (/obj/item/projectile/kinetic): Move
   the kinetic force (/obj/item/projectile/kinetic): process
   Projectiles (/datum/controller/subsystem/processing/projectiles): ignite
   Master (/datum/controller/master): Loop
   Master (/datum/controller/master): StartProcessing

[2024-07-11T05:00:06] Runtime in code/controllers/subsystem/processing/SSdcs.dm:38: list index out of bounds
   proc name: GetIdFromArguments (/datum/controller/subsystem/processing/dcs/proc/GetIdFromArguments)
   usr: Lawliet (CKEY) (/mob/living/carbon/human)
   usr.loc: The floor (167,87,2) (/turf/simulated/floor/plasteel)
   src: Datum Component System (/datum/controller/subsystem/processing/dcs)
   call stack:
   Datum Component System (/datum/controller/subsystem/processing/dcs): GetIdFromArguments
   Datum Component System (/datum/controller/subsystem/processing/dcs): GetElement
   the dark purple baby slime (35... (/mob/living/simple_animal/slime): _RemoveElement
   the dark purple baby slime (35... (/mob/living/simple_animal/slime): remove_atmos_requirements
   the dark purple baby slime (35... (/mob/living/simple_animal/slime): Destroy
   the dark purple baby slime (35... (/mob/living/simple_animal/slime): Destroy
   qdel(the dark purple baby slime (35... (/mob/living/simple_animal/slime), 0)
   /datum/food_processor_process/... (/datum/food_processor_process/mob/slime): process_food
   /datum/food_processor_process/... (/datum/food_processor_process/mob/slime): process_food
   /datum/food_processor_process/... (/datum/food_processor_process/mob/slime): process_food
   Slime Processor (/obj/machinery/processor): attack_hand
   Lawliet (/mob/living/carbon/human): UnarmedAttack
   Lawliet (/mob/living/carbon/human): ClickOn
   Slime Processor (/obj/machinery/processor): MouseDrop

[S34NW]

This PR has been marked as stale due to lack of activity, please continue working on the PR and/or address any comments within 7 days or we will have to close it.

[warriorstar-orion]

This was broken by #25972 which snuck in before it, I've been waiting for @chuga-git to pin down the issue. I'll do a merge master in the meantime.

[S34NW]

#26387 should fix runtimes here

[Danchi299]

class components?
in BYOND programming?
that is surely interesting

[Burzah]

This has been on TM for awhile now after it was adjusted, with no reported issues. Looks good to me.