Transforming as changeling doesnt take clown name in account

[PopGamer45]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

515.1619

Issue Description

I started a round as a Clown Changeling and when i transformed into someone and then transformed back i noticed that in the radio my name wasnt my clown name but my regular character name

What did you expect to happen?

When transforming a person´s clown name should be taken in account

What happened instead?

I wasnt named my clown name but my regular character name

Why is this bad/What are the consequences?

Other players could use this to figure out who is the changeling

Steps to reproduce the issue.

1. Start round as Clown Changeling
2. DNA sting someone
3. transform into them
4. transform back
5. your name is your regular name and not your clown name

When did the problem start happening?

No idea

Extra information

No response

Relevant log output/runtime error

No response

[DGamerL]

Setting your clown name should probably also change your real name

[PopGamer45]

looked at the code real quick and setting your clown name uses the "rename_character" proc which works as intended but the variable "protected_dna" that stores the changelings original dna in the changeling datum sets the original dna before you set your clown name

[DGamerL]

There's probably a way we can access that variable after choosing a clown name?
There's also the issue of bank accounts not being named right IIRC, which is due to the same issue of it setting the bank account name on the server loading everyone in

[silverplatedelta]

Duplicate of #20523. Thank you for the report!