New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify meaning `takerPriceBand` and `makerPriceBand` values #48

Open

hrharder opened this issue Jan 3, 2020 · 0 comments

Assignees

Member

hrharder commented Jan 3, 2020

Motivation:

Re: the feed, "takerPriceBand": [5310, 5790] are those band prices in base units? They probably should be no?

Ultimately what the taker price band refers to is the units of the taker asset received per unit of the maker asset, so unless I am mistaken, it is simply a ratio that would not be affected by weather the maker asset is represented in base units or user units.
That is the reason we encode the maketSizeLimit as a string, but the price band as two numbers.

hrharder self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment