Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating qr_code_scanner to mobile_scanner in talawa mobile #2714

Open
MukalDadhwal opened this issue Jan 23, 2025 · 3 comments
Open

Migrating qr_code_scanner to mobile_scanner in talawa mobile #2714

MukalDadhwal opened this issue Jan 23, 2025 · 3 comments
Assignees

Comments

@MukalDadhwal
Copy link

MukalDadhwal commented Jan 23, 2025

Is your feature request related to a problem? Please describe.
Hey I tried building the app on android 14 which resulted in the following error (image below). The app should be able to build for android 14 as compileSdkVersion is set to 34 but somehow its failing. I tried on android 12 (api level 31) but still the app is failing(which is surprising).

Describe the solution you'd like
Seems like the image_cropper package is using a very old version of flutter which maybe supports <= 31. Upgrading the package resulted in dependency problems with qr_code_scanner which is deprecated.

Describe alternatives you've considered
I resolved the dependency problems internally by migrating qr_code_scanner to mobile_scanner which is latest and is made by the same developer (he recommends using it)

Approach to be followed (optional)
I would like to explain the approach further and update the tests for qr_code_scanner. This would result in the app successfully working for android 14

Additional context

Image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Jan 23, 2025
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@MukalDadhwal MukalDadhwal changed the title Feature Request Migrating qr_code_scanner to mobile_scanner in talawa mobile Jan 23, 2025
@palisadoes
Copy link
Contributor

This should have been fixed in the develop-postgres branch. What branch are you using?

@MukalDadhwal
Copy link
Author

yes i am using develop-postgres branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants