Fixes #1236 Create tests for organization_feed.dart #1478

Ayush0Chaudhary · 2023-02-09T11:28:39Z

What kind of change does this PR introduce?
Fixes #1236 Create tests for organization_feed.dart

Issue Number:

Fixes #1236

Did you add tests for your changes?

Summary
Fixes #1236 Create tests for organization_feed.dart

Does this PR introduce a breaking change?
NO

Have you read the contributing guide?
YES

Ayush0Chaudhary · 2023-02-09T12:17:42Z

I achieved 86.5% coverage

Screen Shot for uncovered part

@palisadoes @noman2002 @TheHazeEffect

literalEval · 2023-02-09T13:52:08Z

@Ayush0Chaudhary do you need help in getting to 100% ?

palisadoes · 2023-02-09T15:23:52Z

We are going to have delay any potential merge until this PR is complete Merge GSoD Work into automated-docs (#1459) #1474
It may cause minor merge conflicts, so be prepared

noman2002

Please try to get it to 100%

Ayush0Chaudhary · 2023-02-10T18:00:38Z

Now the coverage is

codecov-commenter · 2023-02-10T18:08:11Z

Codecov Report

Merging #1478 (cc978d7) into develop (ac0571b) will increase coverage by 0.05%.
The diff coverage is 91.66%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #1478      +/-   ##
===========================================
+ Coverage    78.63%   78.69%   +0.05%     
===========================================
  Files          146      146              
  Lines         7219     7225       +6     
===========================================
+ Hits          5677     5686       +9     
+ Misses        1542     1539       -3

Impacted Files	Coverage Δ
...feed_view_models/organization_feed_view_model.dart	`98.03% <90.90%> (-1.97%)`	⬇️
...ews/after_auth_screens/feed/organization_feed.dart	`89.18% <100.00%> (+10.81%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

palisadoes · 2023-02-10T18:12:28Z

Please fix the linting error

Ayush0Chaudhary · 2023-02-10T18:37:00Z

@noman2002 I was not able to mock stream and and I tried other methods, but was unsuccessful.

Ayush0Chaudhary · 2023-02-10T18:43:24Z

@noman2002 @TheHazeEffect please review!

noman2002 · 2023-02-11T18:27:24Z

@Ayush0Chaudhary Please don't remove reviewers, it is assigned for a purpose. Please refrain from these type of practice.

noman2002 · 2023-02-11T18:28:07Z

@noman2002 I was not able to mock stream and and I tried other methods, but was unsuccessful.

You can take help from @literalEval

palisadoes · 2023-02-11T19:37:58Z

@Ayush0Chaudhary Please don't remove reviewers, it is assigned for a purpose. Please refrain from these type of practice.

I 100% agree. Our volunteers have conflicting priorities and may not always be available on demand, but we are all trying to improve the code base.

Ayush0Chaudhary · 2023-02-11T20:40:48Z

Sorry @palisadoes @noman2002
I tried to ask for re review from Noman and clicked the red icon.

That led to removal of @TheHazeEffect review

It won't happen again, it was not intentional.

palisadoes · 2023-02-11T20:41:34Z

Sorry @palisadoes @noman2002 I tried to ask for re review from Noman and clicked the red icon.

That led to removal of @TheHazeEffect review

It won't happen again, it was not intentional.

Thanks

noman2002 · 2023-02-11T21:55:14Z

lib/view_model/after_auth_view_models/event_view_models/create_event_view_model.dart

@@ -143,6 +143,7 @@ class CreateEventViewModel extends BaseModel {
  Future<void> getImageFromGallery({bool camera = false}) async {
    final _image =
        await _multiMediaPickerService.getPhotoFromGallery(camera: camera);
+    print(_image);


Remove print command.

noman2002 · 2023-02-11T21:56:31Z

lib/view_model/after_auth_view_models/feed_view_models/organization_feed_view_model.dart


    _updatePostSubscription =
        _postService.updatedPostStream.listen((post) => updatedPost(post));
+    print(_posts);


remove print

noman2002 · 2023-02-11T21:57:41Z

test/widget_tests/after_auth_screens/feed/organization_feed_test.dart

+    // tester.allElements.forEach((element) {
+    //   print(element);
+    // });
+
+    // _organizationFeedViewModel.setValueForTest();
+
+    // final u1 = User(
+    //   id: '123',
+    //   firstName: 'John',
+    //   lastName: 'Doe',
+    //   email: '[email protected]',
+    // );
+    // final u2 = User(
+    //   id: '123',
+    //   firstName: 'Ayush',
+    //   lastName: 'Chaudhary',
+    //   email: '[email protected]',
+    // );
+    // final List<User> users = [u1, u2];
+    //
+    // final LikedBy l1 = LikedBy(sId: 'test1');
+    // final LikedBy l2 = LikedBy(sId: 'test2');
+    // final List<LikedBy> likeby = [l1, l2];
+    //
+    // final comment1 = Comments(sId: 'comment1');
+    // final comment2 = Comments(sId: 'comment2');
+    // final comment3 = Comments(sId: 'comment3');
+    // final List<Comments> comments = [comment1, comment2, comment3];
+    //
+    // final myBirthday = DateTime.utc(2004, DateTime.june, 16, 5, 30, 0, 0, 0);
+    // final post = Post(
+    //   creator: User(
+    //     id: '123',
+    //     firstName: 'John',
+    //     lastName: 'Doe',
+    //     email: '[email protected]',
+    //   ),
+    //   sId: "sid",
+    //   createdAt: myBirthday,
+    //   description: 'test description',
+    //   imageUrl: 'https://image.com',
+    //   videoUrl: 'https://image.com',
+    //   organization: OrgInfo(admins: users),
+    //   likedBy: likeby,
+    //   comments: comments,
+    // );
+    // final List<Post> posts = [post];
+    // when(postservice.postStream).
+    // final StreamController<List<Post>> _streamController = StreamController();
+    // final Stream<List<Post>> _stream =
+    //     _streamController.stream.asBroadcastStream();
+
+    // final service = MockPostService();
+    // when(service.postStream).thenAnswer((invocation) {
+    //   return _stream;
+    // });
+    // postservice.postStream.listen((event) {
+    //   print(11);
+    // });
+    // getAndRegisterPostService();
+    // _streamController.add(posts);
+    // await tester.drag(
+    //   find.byType(RefreshIndicator),
+    //   const Offset(0, 200),
+    // );
+
+    // await tester.pumpAndSettle(Duration(milliseconds: 100));
+  });
+}


remove these commented code.

Ayush0Chaudhary · 2023-02-12T22:26:45Z

@noman2002 @palisadoes made the suggested changes.

noman2002

Merge this but let the issue be open.

Ayush0Chaudhary added 7 commits February 7, 2023 02:35

draft

971a204

draft2

f605d9a

draft

c598d40

draft

f604829

draft 2

24539b8

Fixes PalisadoesFoundation#1236 Create tests for organization_feed.dart

52a881a

resolved conflicts

3bea609

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/organization_feed_test branch from 95bf982 to 3bea609 Compare February 9, 2023 11:33

rmv unused imports

589c200

testing issue

a163de5

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/organization_feed_test branch from 4f04f70 to a163de5 Compare February 9, 2023 12:31

palisadoes requested review from noman2002 and TheHazeEffect February 9, 2023 15:24

noman2002 requested changes Feb 9, 2023

View reviewed changes

Improve Coverage

16a14e7

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/organization_feed_test branch from 1f47281 to 16a14e7 Compare February 10, 2023 18:16

Merge branch 'develop' into Ayush0Chaudhary/organization_feed_test

34a6916

Ayush0Chaudhary requested review from noman2002 and removed request for TheHazeEffect February 10, 2023 22:16

noman2002 requested a review from TheHazeEffect February 11, 2023 18:27

noman2002 requested changes Feb 11, 2023

View reviewed changes

Ayush0Chaudhary added 4 commits February 12, 2023 15:14

Update create_event_view_model.dart

7fb481b

Update organization_feed_view_model.dart

7f5988a

Update organization_feed_test.dart

db6ebc2

Update organization_feed_test.dart

cc978d7

noman2002 approved these changes Feb 13, 2023

View reviewed changes

palisadoes approved these changes Feb 13, 2023

View reviewed changes

palisadoes removed the request for review from TheHazeEffect February 13, 2023 21:24

palisadoes approved these changes Feb 13, 2023

View reviewed changes

palisadoes merged commit bdb87b8 into PalisadoesFoundation:develop Feb 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #1236 Create tests for organization_feed.dart #1478

Fixes #1236 Create tests for organization_feed.dart #1478

Ayush0Chaudhary commented Feb 9, 2023

Ayush0Chaudhary commented Feb 9, 2023

literalEval commented Feb 9, 2023

palisadoes commented Feb 9, 2023

noman2002 left a comment

Ayush0Chaudhary commented Feb 10, 2023

codecov-commenter commented Feb 10, 2023 •

edited

Loading

palisadoes commented Feb 10, 2023

Ayush0Chaudhary commented Feb 10, 2023

Ayush0Chaudhary commented Feb 10, 2023

noman2002 commented Feb 11, 2023

noman2002 commented Feb 11, 2023

palisadoes commented Feb 11, 2023

Ayush0Chaudhary commented Feb 11, 2023

palisadoes commented Feb 11, 2023

noman2002 Feb 11, 2023

noman2002 Feb 11, 2023

noman2002 Feb 11, 2023

Ayush0Chaudhary commented Feb 12, 2023

noman2002 left a comment

Fixes #1236 Create tests for organization_feed.dart #1478

Fixes #1236 Create tests for organization_feed.dart #1478

Conversation

Ayush0Chaudhary commented Feb 9, 2023

Ayush0Chaudhary commented Feb 9, 2023

literalEval commented Feb 9, 2023

palisadoes commented Feb 9, 2023

noman2002 left a comment

Choose a reason for hiding this comment

Ayush0Chaudhary commented Feb 10, 2023

codecov-commenter commented Feb 10, 2023 • edited Loading

Codecov Report

palisadoes commented Feb 10, 2023

Ayush0Chaudhary commented Feb 10, 2023

Ayush0Chaudhary commented Feb 10, 2023

noman2002 commented Feb 11, 2023

noman2002 commented Feb 11, 2023

palisadoes commented Feb 11, 2023

Ayush0Chaudhary commented Feb 11, 2023

palisadoes commented Feb 11, 2023

noman2002 Feb 11, 2023

Choose a reason for hiding this comment

noman2002 Feb 11, 2023

Choose a reason for hiding this comment

noman2002 Feb 11, 2023

Choose a reason for hiding this comment

Ayush0Chaudhary commented Feb 12, 2023

noman2002 left a comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 10, 2023 •

edited

Loading