Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma: Refactor Search Bar CSS #3369

Open
palisadoes opened this issue Jan 20, 2025 · 2 comments
Open

Figma: Refactor Search Bar CSS #3369

palisadoes opened this issue Jan 20, 2025 · 2 comments
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 20, 2025

Introduction

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Post a video of your work in the PR

  1. This is important for reviewers to understand the solution
  2. Pay attention to the Additional Information below.

Is your feature request related to a problem? Please describe.

  1. There is no consistent approach to Search bars and associated drop downs across the application
  2. There needs to be a standard using usable code and CSS

Additional Information

  1. When in doubt about colors, take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  2. The desired single CSS file for your changes is:
    1. src/style/app.module.css
  3. Use no CSS in:
    1. assets/css/app.css
  4. Use CSS variable names that describe the function of the color and not the color itself. This will help with future attempts to having Dark Mode.
    1. For example --search-button-bg is much better than --light-blue
    2. NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296
  5. Buttons, and dropdowns must only have shadows when there is a mouse hover. Their color must not change
  6. Search boxes must only have shadows when selected

Additional context

Image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 20, 2025
@palisadoes palisadoes changed the title Refactor Search Bar CSS Figma: Refactor Search Bar CSS Jan 20, 2025
@eizadhamdan
Copy link

@palisadoes please assign this issue to me

@MayankJha014
Copy link
Contributor

@palisadoes Assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

3 participants