-
-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma: Admin and User Chat Pages Violate The Figma Style Guide #3201
Comments
Can I work on this issue? |
@swastikCommits You have closed 4 PRs without merging. This will need to be assigned to someone with more recent success |
can i work on this issue |
Can I work on the issue? |
Hey ! can you assign me this issue ? |
@palisadoes can I work on this? |
@palisadoes "Hey, I’m already working on similar issues and would really like to take on this one as well. However, since I currently have other assigned issues, I’d prefer to complete them first before starting on this. If no one else gets assigned in the meantime, I’d be happy to take it up once I finish my existing tasks." |
@palisadoes Thankyou for assigning , I wil raise PR Soon |
I want to work on this issue, please assign it to me. |
@Shahmaz0 Thankyou for you interest ,. but I've sorted this out will raise a PR soon . |
We created an this issue to do basic changes to the CSS colors for consistency The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly. We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read. When this is done we'll need your assistance to merge the screens into the If your screens have not been affected, then you should use the new methodology to refactor them. This is an extraordinary circumstance. I hope you will appreciate the decision. |
Problem 1: The sign out button and user toggle section doesn't match to figma fileFigma File : If you want this to be corrected . Do let me know . |
Yes in the context of the work I mentioned earlier today |
Alright ! @palisadoes could you please elaborate a bit that i have to create issues only or should i raise the PR ? |
Yes create issues. You don't have to ask to create issues |
Alright !! Thankyou . |
Please proceed. The changes mentioned previously are mostly in components |
Post a video of your work in the PR
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
src/style/app.module.css
Other
Your design must accommodate:
A database with and without:
Fewer pinned posts than will spread across the screen
There must be no gaps between the search bar and posts if pinned posts no longer exist
The foundational work for this was completed in this PR:
When in doubt about colors, take cues from other similar elements in this file and the PR mentioned in the issue.
The desired single CSS file is:
src/style/app.module.css
src/style/app.module.css
file must be the only source of CSSUse no CSS in:
assets/css/app.css
Use variable names that describe the function of the color and not the color itself. This will help with future attempts to having Dark Mode.
--search-button-bg
is much better than--light-blue
When refactoring modals, please refer to this PR that has created a standardized design patter for them.
Remove all references to HTML color codes in the files you edit except in
src/style/app.module.css
Buttons, and dropdowns must only have shadows when there is a mouse hover. Their color must not change
Search boxes must only have shadows when selected
Figma Style Guide
Screenshots
If applicable, add screenshots to help explain your problem.
Additional details
Add any other context or screenshots about the feature request here.
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: