Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma: Admin and User Chat Pages Violate The Figma Style Guide #3201

Open
palisadoes opened this issue Jan 7, 2025 · 17 comments
Open

Figma: Admin and User Chat Pages Violate The Figma Style Guide #3201

palisadoes opened this issue Jan 7, 2025 · 17 comments
Assignees
Labels
bug Something isn't working feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 7, 2025

Post a video of your work in the PR

  • Pay special attention to the Other section below
  • This is a complex issue for persons with significant merging experience in the repository

Describe the bug

  1. Admin and User Chat Pages Violate The Figma Style Guide

To Reproduce
Steps to reproduce the behavior:

  1. Style Related
    1. Login to the app as a User
    2. Select an organization
    3. Select people
    4. The figma guide is not followed fully

Expected behavior

  1. The screens shown must conform to Figma
  2. This must apply to the following where relevant:
    1. Users
    2. Admins
    3. SuperAdmins
  3. Tests must be written to ensure this does not happen again
  4. The CSS must be consolidated into this file using variables wherever possible
    1. src/style/app.module.css

Other

Your design must accommodate:

  1. A database with and without:

    1. Pinned posts
    2. Regular posts
  2. Fewer pinned posts than will spread across the screen

  3. There must be no gaps between the search bar and posts if pinned posts no longer exist

  4. The foundational work for this was completed in this PR:

  5. When in doubt about colors, take cues from other similar elements in this file and the PR mentioned in the issue.

    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  6. The desired single CSS file is:

    1. src/style/app.module.css
      1. Convert all code files to use this file.
      2. Delete all CSS files in this code path and below mentioned in the title. The src/style/app.module.css file must be the only source of CSS
  7. Use no CSS in:

    1. assets/css/app.css
  8. Use variable names that describe the function of the color and not the color itself. This will help with future attempts to having Dark Mode.

    1. For example --search-button-bg is much better than --light-blue
    2. NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296
  9. When refactoring modals, please refer to this PR that has created a standardized design patter for them.

    1. Updating to NEW COLOR SCHEME #2984
  10. Remove all references to HTML color codes in the files you edit except in src/style/app.module.css

  11. Buttons, and dropdowns must only have shadows when there is a mouse hover. Their color must not change

  12. Search boxes must only have shadows when selected

Figma Style Guide

  1. We are migrating away from the green theme as part of our support for color blind users.
  2. Take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. Use a variable instead. There are appropriate blue/grey colors that have been used in other screens

Screenshots
If applicable, add screenshots to help explain your problem.

  1. User Portal
    image
  2. Admin Portal
    image
  3. Admin Portal scrolling
    image

Additional details
Add any other context or screenshots about the feature request here.

  1. Background color guide - Use these instead of those that may be different in sample pages below. Our Figma design is not consistent
    image
  2. Update as per Figma with these modifications
    image
  3. Horizontal scroll for pinned posts
    image
  4. Fixed width
    image
  5. Post detail
    image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 7, 2025
@github-actions github-actions bot added feature request ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 7, 2025
@swastikCommits
Copy link

Can I work on this issue?

@palisadoes
Copy link
Contributor Author

@swastikCommits You have closed 4 PRs without merging. This will need to be assigned to someone with more recent success

@khushipatil1523
Copy link
Contributor

can i work on this issue

@harshk-89
Copy link

Can I work on the issue?

@Abdul-Moiz31
Copy link

Hey ! can you assign me this issue ?
Woud love to work on this

@aadhil2k4
Copy link
Contributor

@palisadoes can I work on this?

@rahulch07
Copy link
Contributor

@palisadoes "Hey, I’m already working on similar issues and would really like to take on this one as well. However, since I currently have other assigned issues, I’d prefer to complete them first before starting on this. If no one else gets assigned in the meantime, I’d be happy to take it up once I finish my existing tasks."

@Abdul-Moiz31
Copy link

@palisadoes Thankyou for assigning , I wil raise PR Soon

@Shahmaz0
Copy link

I want to work on this issue, please assign it to me.

@Abdul-Moiz31
Copy link

@Shahmaz0 Thankyou for you interest ,. but I've sorted this out will raise a PR soon .

@palisadoes
Copy link
Contributor Author

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

@Abdul-Moiz31
Copy link

Abdul-Moiz31 commented Jan 14, 2025

@palisadoes

Problem 1: The sign out button and user toggle section doesn't match to figma file

Design Now :
Screenshot 2025-01-14 200239

Figma File :

Talawa1

If you want this to be corrected . Do let me know .
Can i work on this issue too ?

@palisadoes
Copy link
Contributor Author

Yes in the context of the work I mentioned earlier today

@Abdul-Moiz31
Copy link

Alright ! @palisadoes could you please elaborate a bit that i have to create issues only or should i raise the PR ?
Guidance would be helpful
Thanks in advance !

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 14, 2025

Yes create issues. You don't have to ask to create issues

@Abdul-Moiz31
Copy link

Alright !! Thankyou .

@palisadoes
Copy link
Contributor Author

Please proceed. The changes mentioned previously are mostly in components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Status: Backlog
Development

No branches or pull requests

8 participants