Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma User Portal: Organization Left Drawer Violates The Figma Style Guide #3198

Open
palisadoes opened this issue Jan 7, 2025 · 28 comments
Assignees
Labels
bug Something isn't working feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 7, 2025

Post a video of your work in the PR

Describe the bug

  1. User Portal: Organization Left Drawer Violates The Figma Style Guide

To Reproduce
Steps to reproduce the behavior:

  1. Style Related
    1. Login to the app as a User
    2. Select an organization
    3. The figma guide is not followed fully

Expected behavior

  1. The screens shown must conform to Figma
  2. This must apply to the following where relevant:
    1. Users
    2. Admins
    3. SuperAdmins
  3. Tests must be written to ensure this does not happen again
  4. The CSS must be consolidated into this file using variables wherever possible
    1. src/style/app.module.css

Other

  1. The foundational work for this was completed in this PR:
  2. When in doubt about colors, take cues from other similar elements in this file and the PR mentioned in the issue.
    1. https://www.figma.com/design/dmKt00m9GVSeA1nebnkxql/Untitled?node-id=0-1&node-type=canvas&t=TPzfh1DE9IxjzsEe-0
  3. The desired single CSS file is:
    1. src/style/app.module.css
      1. Convert all code files to use this file.
      2. Delete all CSS files in this code path and below mentioned in the title. The src/style/app.module.css file must be the only source of CSS
  4. Use no CSS in:
    1. assets/css/app.css
  5. Use variable names that describe the function of the color and not the color itself. This will help with future attempts to having Dark Mode.
    1. For example --search-button-bg is much better than --light-blue
    2. NoMongo: Fix Stylesheet in Anticipation of Dark Mode #3296
  6. When refactoring modals, please refer to this PR that has created a standardized design patter for them.
    1. Updating to NEW COLOR SCHEME #2984
  7. Remove all references to HTML color codes in the files you edit except in src/style/app.module.css
  8. Buttons, and dropdowns must only have shadows when there is a mouse hover. Their color must not change
  9. Search boxes must only have shadows when selected

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional details
Add any other context or screenshots about the feature request here.

  1. Background color guide - Use these instead of those that may be different in sample pages below. Our Figma design is not consistent
    image
  2. Update as per Figma with these modifications
    image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Jan 7, 2025
@github-actions github-actions bot added feature request ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Jan 7, 2025
@aryanrule
Copy link

sir can you please assign me this

@Abdul-Moiz31
Copy link

Hello @palisadoes Can you assign this issue to me ?

@Cioppolo14
Copy link
Contributor

If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@palisadoes
Copy link
Contributor Author

We created an this issue to do basic changes to the CSS colors for consistency

The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly.

We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read.

When this is done we'll need your assistance to merge the screens into the develop branch with this issue.

If your screens have not been affected, then you should use the new methodology to refactor them.

This is an extraordinary circumstance. I hope you will appreciate the decision.

@palisadoes
Copy link
Contributor Author

Please proceed. The changes mentioned previously are mostly in components

@palisadoes
Copy link
Contributor Author

@aryanrule Are you still working on this?

@hustlernik
Copy link
Contributor

@palisadoes assign me if no one is working.

@palisadoes palisadoes assigned hustlernik and unassigned aryanrule Jan 18, 2025
@hustlernik
Copy link
Contributor

not having much space for sidebar footer (user profile and sign out), should I put scroll?

Image

Image

@palisadoes
Copy link
Contributor Author

  1. Yes with the tiniest reasonable width.
  2. Use Gmail as a guide. The scroll bar only appears when hovering
  3. Also, I'm wondering whether it would be better to use a white background versus grey. It would:
    1. Make the light blue background of the right panel be more noticeable.
    2. Make the text easier to read
    3. Make the highlighted options more visible.

Please try the white background. The Figma isn't always ideal

@hustlernik
Copy link
Contributor

@palisadoes I'm trying and will let you know.

@hustlernik
Copy link
Contributor

I guess white background looks better.
Image

@palisadoes
Copy link
Contributor Author

Let's do white

@palisadoes
Copy link
Contributor Author

  1. In Gmail the scroll bar only appears when you hover over the left nav
  2. We'll need to do this. The left nav profile will need to have the same functions as the dropdown here.
    Image

Image

@palisadoes
Copy link
Contributor Author

  1. When would you be able to raise a PR?
  2. This is a key design element
  3. Ideally it should be merged before this PR. Which may happen in the next 24 hours.

@hustlernik
Copy link
Contributor

hustlernik commented Jan 24, 2025

@palisadoes I have done this, almost. Will raise after writing some test and refactoring, in 2hrs approx.

@hustlernik
Copy link
Contributor

Image

@hustlernik
Copy link
Contributor

@palisadoes I have created two new component.

  1. Profile Card
  2. Sign Out

On hover scroll bar appears.

@hustlernik
Copy link
Contributor

this error coming while commit
Image

@hustlernik
Copy link
Contributor

hustlernik commented Jan 24, 2025

@palisadoes pre commit hook failing

@palisadoes
Copy link
Contributor Author

There may be local storage statements in your code that don't use the localstorage libray

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 24, 2025

  1. Please open a PR
  2. Attach a video in the PR too

@hustlernik
Copy link
Contributor

@palisadoes Getting this issue
Image

@palisadoes
Copy link
Contributor Author

  1. Are you running this on windows, MacOS/linux or WSL?
  2. I have no errors in linux
  3. Use the git commit --no-verify -am to skip the local tests. We need to get this merged in the next few hours. A major PR is about be merged and this will break.

@hustlernik
Copy link
Contributor

windows, okay I am onto it.

@palisadoes
Copy link
Contributor Author

Please create an issue to fix npx tsx ./scripts/githooks/check-localstorage-usage.ts running on Windows. We can't have this again

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 25, 2025

@palisadoes palisadoes reopened this Jan 25, 2025
@github-project-automation github-project-automation bot moved this from Done to In progress in 2024 New Talawa Admin Screens Jan 25, 2025
@hustlernik
Copy link
Contributor

hustlernik commented Jan 25, 2025

@palisadoes Should I again raise the PR after fixing lint?

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 26, 2025

Reopening. Please update this

  1. There are several outstanding issues
    Image
  2. Gmail uses grey for hovering over a left drawer item, and blue for selected items. We should use that.
    Image
  3. More
    Image
  4. Remove the hiding of the drawer. It'll create support issues. We removed it from talawa-docs for this reason
    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: In progress
Development

No branches or pull requests

5 participants