-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma User Portal: Organization Left Drawer Violates The Figma Style Guide #3198
Comments
sir can you please assign me this |
Hello @palisadoes Can you assign this issue to me ? |
If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance. |
We created an this issue to do basic changes to the CSS colors for consistency The resulting PR created a comprehensive design system for the entire app. This was unexpected. The approach was a long term goal that became immediately implementable. We had to act promptly. We have just merged the PR. There will be a follow up PR to adjust some colors as the Figma design has lettering that is sometimes hard to read. When this is done we'll need your assistance to merge the screens into the If your screens have not been affected, then you should use the new methodology to refactor them. This is an extraordinary circumstance. I hope you will appreciate the decision. |
Please proceed. The changes mentioned previously are mostly in components |
@aryanrule Are you still working on this? |
@palisadoes assign me if no one is working. |
Please try the white background. The Figma isn't always ideal |
@palisadoes I'm trying and will let you know. |
Let's do white |
|
@palisadoes I have done this, almost. Will raise after writing some test and refactoring, in 2hrs approx. |
@palisadoes I have created two new component.
On hover scroll bar appears. |
@palisadoes pre commit hook failing |
There may be local storage statements in your code that don't use the localstorage libray |
|
@palisadoes Getting this issue |
|
windows, okay I am onto it. |
Please create an issue to fix |
@hustlernik We had to revert your PR. There was a breaking change |
@palisadoes Should I again raise the PR after fixing lint? |
Post a video of your work in the PR
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Expected behavior
src/style/app.module.css
Other
src/style/app.module.css
src/style/app.module.css
file must be the only source of CSSassets/css/app.css
--search-button-bg
is much better than--light-blue
src/style/app.module.css
Screenshots
If applicable, add screenshots to help explain your problem.
Additional details
Add any other context or screenshots about the feature request here.
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: