-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Task File Deployment and Execution #419
Open
jjoderis
wants to merge
25
commits into
main
Choose a base branch
from
engine/script-file-deployment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a script task is referencing a script file that file is added to the process versions dependencies
…ript-file-deployment
Added handling of script file references in script tasks during the execution of processes in the engine
- if a process containing script tasks that reference script files is versioned then the scripts are also versioned - if a process bpmn is exported scripts are included in the export when the option for artefacts is selected - scripts are deployed with the other process data when a process version is deployed to an engine
This comment has been minimized.
This comment has been minimized.
… a process is versioned; script/user task file versions are not reused when there is no change in the new version from the version it is based on
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jjoderis
commented
Jan 9, 2025
@@ -86,7 +86,7 @@ for (const objName of Object.keys(structure)) { | |||
for (const functionName of functionNames) { | |||
context.evalClosureSync( | |||
`globalThis["${objName}"]["${functionName}"] = function (...args) { | |||
return $0.applySyncPromise(null, [JSON.stringify(args)], {}).copyInto(); | |||
return $0.applySyncPromise(null, [JSON.stringify(args)], {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FelipeTrost could you have a look at this. This should fix that accessing the instance variables from a script task currently does not work on main.
…r task editor the editor toolbar is stuck on the mobile layout button and does not allow layout changes
This comment has been minimized.
This comment has been minimized.
✅ Successfully created Preview Deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added functionality to deploy scripts that are stored in separate files and added handling for script files during process execution
Closes: #418
Details