Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Task File Deployment and Execution #419

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

jjoderis
Copy link
Contributor

@jjoderis jjoderis commented Nov 21, 2024

Summary

Added functionality to deploy scripts that are stored in separate files and added handling for script files during process execution

Closes: #418

Details

  • if a process version is created of a process containing script tasks that reference files, the versions of the script files are also created
  • scripts are exported with the process bpmn if the option to export artefacts is selected
  • scripts are deployed to the engine as separate files when a process with references to script files is deployed
  • if a script task that references a file is executed the script is loaded from the file and added to the script task allowing it to be used by the neo-bpmn-engine

… a script task is referencing a script file that file is added to the process versions dependencies
Added handling of script file references in script tasks during the
execution of processes in the engine
- if a process containing script tasks that reference script files is
versioned then the scripts are also versioned
- if a process bpmn is exported scripts are included in the export when
the option for artefacts is selected
- scripts are deployed with the other process data when a process
version is deployed to an engine

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@@ -86,7 +86,7 @@ for (const objName of Object.keys(structure)) {
for (const functionName of functionNames) {
context.evalClosureSync(
`globalThis["${objName}"]["${functionName}"] = function (...args) {
return $0.applySyncPromise(null, [JSON.stringify(args)], {}).copyInto();
return $0.applySyncPromise(null, [JSON.stringify(args)], {});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FelipeTrost could you have a look at this. This should fix that accessing the instance variables from a script task currently does not work on main.

…r task editor the editor toolbar is stuck on the mobile layout button and does not allow layout changes
@jjoderis jjoderis requested a review from anishsapkota January 9, 2025 17:38
@jjoderis jjoderis marked this pull request as ready for review January 9, 2025 17:38

This comment has been minimized.

Copy link

github-actions bot commented Jan 9, 2025

CLOUDRUN ACTIONS

✅ Successfully created Preview Deployment.

https://pr-419---ms-server-staging-c4f6qdpj7q-ew.a.run.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing Script Files on Engine
1 participant