Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a prefs zustand store #113

Closed
OhKai opened this issue Oct 9, 2023 · 0 comments · Fixed by #135
Closed

Make a prefs zustand store #113

OhKai opened this issue Oct 9, 2023 · 0 comments · Fixed by #135

Comments

@OhKai
Copy link
Contributor

OhKai commented Oct 9, 2023

The prefs are currently not reactive (just read on render). When a component makes a pref change (e.g. the sidepanel in the processes view) other components relying on that pref don't know about it. This lead to some extra code, just to trigger a rerender in the icon list view when the pref changes.

Instead, we should implement prefs in a zustand store so that it can be shared across components and changes are reactive on all dependent components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant