Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry publishing a comment that failed to publish #2100

Open
thewilkybarkid opened this issue Nov 21, 2024 · 0 comments
Open

Retry publishing a comment that failed to publish #2100

thewilkybarkid opened this issue Nov 21, 2024 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

No description provided.

erkannt added a commit that referenced this issue Nov 21, 2024
@erkannt
Sketch a test list for finding comments in need of a DOI
4cf3733 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 21, 2024
@thewilkybarkid
Implement a test
6957fb7 
Refs #2100
erkannt added a commit that referenced this issue Nov 21, 2024
@erkannt
Implement another test
e96a451 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 21, 2024
@thewilkybarkid
Make it easier to implement other test cases
568d173 
Refs #2100
erkannt added a commit that referenced this issue Nov 21, 2024
@erkannt
Implement a failing test
8c6b40d 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 21, 2024
@thewilkybarkid
Make a test pass
665222a 
Refs #2100
erkannt added a commit that referenced this issue Nov 21, 2024
@erkannt
Remove an unused argument
9b00c33 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 21, 2024
@thewilkybarkid
Fix a find-and-replace mistake
7d83519 
Refs #2100, e445fe8
thewilkybarkid added a commit that referenced this issue Nov 21, 2024
@thewilkybarkid
Move towards using queries to inform sagas
4d1a2ad 
Refs #2100
erkannt added a commit that referenced this issue Nov 21, 2024
@erkannt
Handle cases where we have failed to assign a DOI
233781a 
Refs: #2100
erkannt added a commit that referenced this issue Nov 22, 2024
@erkannt
Rename to better express responsibility
fe29952 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Narrow down an interface to match the requirements
6c5b4b8 
Refs #2100
erkannt added a commit that referenced this issue Nov 22, 2024
@erkannt
Expand responsibility of query to return all information needed for t…
b2431c2 
…he reaction

Currently using stubbed data to satisfy the new signature.

Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Update test to reflect new responsibility of query
b58e9bf 
Refs #2100
erkannt added a commit that referenced this issue Nov 22, 2024
@erkannt
Make a test pass
9adb976 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Surface when we encounter invalid sequences of events
7a696a8 
Refs #2100
erkannt added a commit that referenced this issue Nov 22, 2024
@erkannt
Make use of expanded query, reducing the places where GetComment is used
06cd3de 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Ensure we log details of what went wrong
1d60845 
Refs #2100
erkannt added a commit that referenced this issue Nov 22, 2024
@erkannt
Make handling of different unhappy paths easier to read
b039559 
Refs: #2100
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Consistently log with more context
3ab4ff0 
Refs #2100
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Make it easier to read
05c3b51 
Refs #2100, 233781a, https://effect.website/docs/concurrency/fibers/#fork-with-automatic-supervision
thewilkybarkid added a commit that referenced this issue Nov 22, 2024
@thewilkybarkid
Make it easier to read
206d058 
Refs #2100
thewilkybarkid added a commit that referenced this issue Nov 25, 2024
@thewilkybarkid
Expand the test list
3b0810e 
Refs #2100, 7a696a8
thewilkybarkid added a commit that referenced this issue Nov 25, 2024
@thewilkybarkid
Improve a name
15a99df 
Refs #2100
thewilkybarkid added a commit that referenced this issue Nov 25, 2024
@thewilkybarkid
Implement a test
3a37288 
Refs #2100
thewilkybarkid added a commit that referenced this issue Nov 25, 2024
@thewilkybarkid
Implement a test and rename to match current behaviour
f158d7e 
Refs #2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid