Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the CSV importer data #22

Open
simardeep1792 opened this issue Apr 30, 2024 · 9 comments
Open

Issue with the CSV importer data #22

simardeep1792 opened this issue Apr 30, 2024 · 9 comments
Assignees

Comments

@simardeep1792
Copy link
Collaborator

Hi @gagandeepsingh1105 ,

Could you investigate an issue with our current Pelias instance? According to @NickZachary , there seems to be a problem when API requests are sent to the CSV data. Although the data exists, the response we receive is the centroid of the data instead of the original geocoding locations. Additionally, the accuracy appears to be incorrect.

I have attached some screenshots that @NickZachary shared with me for your reference.

image

image

@simardeep1792
Copy link
Collaborator Author

@gagandeepsingh1105 if you need more insights feel free to connect with me or @NickZachary.

@gagandeepsingh1105
Copy link
Collaborator

Sure @simardeep1792 , I'll start working on it and let you know if I need any support.

@NickZachary
Copy link

My thoughts on this:

  • we confirmed that the address queried exists in the original StatCan CSV and the lat/long is rooftop.
  • The same address resolves to rooftop point using the OSM data in the Pelias instance
  • Looking at the returned JSON response from the souce=other (i.e. StatCan) you can see that the address was normalized and ought to just be a straight up textual match in ElasticSearch. We know that it should exists if the input csvs from csv-importer worked correctly.

@simardeep1792
Copy link
Collaborator Author

@gagandeepsingh1105 do we have any updates on the testing? Can we do a quick test run on this as @NickZachary is recommending?

@gagandeepsingh1105
Copy link
Collaborator

Hi @NickZachary , can we connect to quickly discuss the approach for further testing the csv-import functionality.

Thanks

@gagandeepsingh1105
Copy link
Collaborator

gagandeepsingh1105 commented May 22, 2024

As discussed with the team, after trying a couple of configurations changes to resolve the issue of confidence level dropping to 0.6 when city name is included in the text search , we decided to open a git hub issue for Pelias open community: pelias/csv-importer#107

@simardeep1792
Copy link
Collaborator Author

@gagandeepsingh1105

Could you please provide an update on this issue? It appears that members of the community have responded.

@gagandeepsingh1105
Copy link
Collaborator

Hi @simardeep1792 , the response on the git hub issue by Pelias community doesn't provide enough explanation for the behavior we have noticed when including city names in the search. So, James Logan (from Zac's team) has put in another comment in the issue seeking for a more relevant explanation/reasoning.

@simardeep1792
Copy link
Collaborator Author

@gagandeepsingh1105 Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants