Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in checking DF format #3

Closed
doctor-yes opened this issue Oct 16, 2022 · 1 comment
Closed

A bug in checking DF format #3

doctor-yes opened this issue Oct 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@doctor-yes
Copy link

in dftt_timecode\core.py line 90:

if mm % 10 != 0 and ff in (0, drop_per_min - 1):

This is enforcing skip frame for every second which is incorrect, it should be only enforcing at the beginning of the minute. Suggest to change it to:

if mm % 10 != 0 and ss==00 and ff in (0, drop_per_min - 1):

@OwenYou
Copy link
Owner

OwenYou commented Oct 16, 2022

Thanks for the comment, this bug is already fixed in #2.
: )

@OwenYou OwenYou closed this as completed Oct 16, 2022
@OwenYou OwenYou added the bug Something isn't working label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants