Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Plotting #142

Open
ericasaw opened this issue Jun 29, 2023 · 1 comment
Open

Question about Plotting #142

ericasaw opened this issue Jun 29, 2023 · 1 comment

Comments

@ericasaw
Copy link
Collaborator

I feel like we once had a discussion about why the native plot function uses .step() instead of .plot(), but I can't remember the reasoning for it anymore. Was wondering if we could add a keyword so users can choose to use .plot instead of .step in the plotting function.

@gully
Copy link
Member

gully commented Jun 29, 2023

It's mostly preference. Step emphasizes the pixel-based quantization of spectra, which I think is useful. My weak preference would be not to add an an option for .plot(), but I am open to it. In general my guidance on updates to plots would be to mimic---almost verbatim---the way that lightkurve does plotting:

https://github.com/lightkurve/lightkurve/blob/566803b9ff59f8638af413aad5bf27dddbbc2583/src/lightkurve/lightcurve.py#L1819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants