Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check instead of fix #113

Open
garak opened this issue Jan 24, 2025 · 0 comments
Open

Check instead of fix #113

garak opened this issue Jan 24, 2025 · 0 comments

Comments

@garak
Copy link

garak commented Jan 24, 2025

The main use of this action should be to check if some PR breaks your coding standard.
Currently, it instead fixes the code, which is pointless (the fixed code is in the CI container, not your actual code).

The only way to get the intended behaviour is currently to use this configuration:

with:
    args: --dry-run

You should change this line to read like the following:

/usr/local/bin/php-cs-fixer check $*

If you don't want to change it, you should at least give a big warning in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant