Intentional fallthroughs?

[r-barnes]

Is the fallthrough on this line from the underscore case to the asterisk case intentional?

If not, can we use a break; to fix the bug? If so, can we use __attribute__((fallthrough)); to mark it as explicit?

[r-barnes]

The fallthrough here looks as though it is probably intentional - just double checking, though - is it?

[Orc]

Yes, that is intentional; if a leading emphasis looks like two characters, I first look for a two character match and if that fails I fall back to a one character match.

…

-jessica l. parsons

On Jul 1, 2024, at 6:08 AM, Richard Barnes ***@***.***> wrote: The fallthrough here <https://github.com/Orc/discount/blob/5e2f73aec4025b23a6d1c85b6c62f9653cccd9b9/emmatch.c#L114> looks as though it is probably intentional - just double checking, though - is it? — Reply to this email directly, view it on GitHub <#287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAE5AR3SOMBE63DF6FOPY3ZKFIF7AVCNFSM6AAAAABJUFHOWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGA4TSNBUGU>. You are receiving this because you are subscribed to this thread.

[r-barnes]

@Orc - Thanks, I've put up #288

What about the underscore->asterisk fallthrough here?

[Orc]

I'm going to close this issue because switch fallthrough is part of the language (c.f. Duff's Device)