Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify hook impl in erc20_votes mock #1015

Closed
andrew-fleming opened this issue Jun 17, 2024 · 2 comments
Closed

Simplify hook impl in erc20_votes mock #1015

andrew-fleming opened this issue Jun 17, 2024 · 2 comments
Assignees
@ggonzalez94
Milestone
1. current

Comments

@andrew-fleming
Copy link
Collaborator

We can simplify the hooks implementation by passing in the mock's ContractState instead of the component's state. See the examples in Extending Contracts with Hooks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Jun 17, 2024
@ericnordelo ericnordelo added this to the 2. next milestone Sep 25, 2024
@andrew-fleming andrew-fleming mentioned this issue Oct 14, 2024
Merged
4 tasks
@ggonzalez94
Copy link
Collaborator

Should be closed once we merge #1114

@ggonzalez94 ggonzalez94 modified the milestones: 2. next, 1. current Oct 15, 2024
@ggonzalez94 ggonzalez94 self-assigned this Oct 16, 2024
@ggonzalez94
Copy link
Collaborator

Closing now that #1114 was merged and the votes mocks were refactored

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Resolved in Contracts for Cairo Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggonzalez94 ggonzalez94

Labels
None yet
Projects
Contracts for Cairo
Archived in project
Milestone
1. current
Development

No branches or pull requests
3 participants
@ggonzalez94 @ericnordelo @andrew-fleming