Remove add exports for sun.security.action from our tool script template #30628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
There were 3 new failing FATs that were intermittent and 4 existing failing FATs that are known, unrelated issues. |
jhanders34
requested changes
Jan 27, 2025
gjwatts
force-pushed
the
remove-sun-security-action-from-tool-java-24
branch
from
767892b to
020eaca
Compare
jhanders34
approved these changes
Jan 27, 2025
|
!build Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Fixes #30627
Currently we are adding:
to our automatic scripts, via the tool template, when running on any JVM that is version 9 or higher.
In Java 24, Oracle removed
sun.security.actionfrom thejava.basemodule, so when we add the--add-exportsabove, it gives us a warning thatsun.security.actionis not injava.base, like this:This message shows up in our console log and interferes with some of our testing. Since Open Liberty does not require anything in
sun.security.action, we are removing the above--add-exportsfrom our tool script template.