Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR checker to check the artifact id #773

Open
priyyanshi opened this issue Jan 24, 2022 · 1 comment
Open

Update PR checker to check the artifact id #773

priyyanshi opened this issue Jan 24, 2022 · 1 comment
Assignees
@shin19991207
Labels
enhancement

Comments

@priyyanshi
Copy link
Contributor

priyyanshi commented Jan 24, 2022 •
edited by gkwan-ibm
Loading

The artifact id for a guide should be be prefixed with the guide's project id. For example, artifact id should be guide-containerize-podman-system instead of system.

Source of PR checker: https://github.com/OpenLiberty/guides-common/tree/prod/pr-checker
@shin19991207 shin19991207 self-assigned this Nov 5, 2024
@shin19991207 shin19991207 mentioned this issue Nov 5, 2024
Open
@gkwan-ibm
Copy link
Member

Put this issue to icebox

  • most guides already use the right artifact id
  • for new guides, it can be spotted by manual review
  • so complicated if completely check webApplication, application, and enterpriseApplication elements in server.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shin19991207 shin19991207

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gkwan-ibm @priyyanshi @shin19991207