Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Variable Cleanup? #41

Open
vbhayden opened this issue May 5, 2022 · 0 comments
Open

Environment Variable Cleanup? #41

vbhayden opened this issue May 5, 2022 · 0 comments

Comments

@vbhayden
Copy link

vbhayden commented May 5, 2022

Morning team!

With ECC implementation for a few of our sandboxes coming up, I am going through and trying to simplify the deployment documentation into the barebones, "what do I need to type" instructions.

For this repo (and a few others), there are a few environment variables that seem to have just been copy / pasted from other repos but that are unused by this one:

  • AWS_SECRET_ACCESS_KEY
  • AWS_ACCESS_KEY_ID
  • AWS_DEFAULT_REGION
  • AWS_CA_BUNDLE
  • REQUESTS_CA_BUNDLE

There are also a few that are used but undocumented:

  • BAD_HOST
  • OVERIDE_HOST

Lastly, the MySQL setup seems a bit odd, as DB_USER is used by Django but not by MySQL etc.

We can submit a PR to clean some of this up if that would help? For folks like me that skim to the meat + potatoes of setup right away, reducing environment variable intimidating is always a good thing imo.

Thanks!
-Trey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant