From 39af9fa399483348abf4e0c4358271cfd74188d8 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:03:58 +0100 Subject: [PATCH 01/15] first test (should work) for running actions only once on PR --- .github/workflows/test-workflow.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 6d34f61a..50cb2d47 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -15,7 +15,16 @@ env: dir: '../' conf: '../../conf.json.example' jobs: + check-double-run: + runs-on: ubuntu-latest + steps: + - uses: rlespinasse/github-slug-action@v3.x + - run: echo ${{ GITHUB_REPOSITORY_OWNER_PART }} + - name: Cancel this build + uses: andymckay/cancel-action@0.2 + if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART != "OpenFactorioServerManager" test-npm: + needs: [ check-double-run ] strategy: matrix: os: [ubuntu-latest, windows-latest] @@ -25,6 +34,7 @@ jobs: - uses: actions/setup-node@v1 - run: make app/bundle test-go: + needs: [check-double-run] strategy: matrix: os: [ubuntu-latest, windows-latest] From 65515fdca0feca480a82b00fd1d4c9a1d982b9b5 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:09:00 +0100 Subject: [PATCH 02/15] fix wrong syntax --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 50cb2d47..30508808 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo ${{ GITHUB_REPOSITORY_OWNER_PART }} + - run: echo $GITHUB_REPOSITORY_OWNER_PART - name: Cancel this build uses: andymckay/cancel-action@0.2 if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART != "OpenFactorioServerManager" From 3b807b5d23fd04f3e7784edf39e59579c14910c3 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:10:10 +0100 Subject: [PATCH 03/15] fix wrong syntax v2 --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 30508808..c74f06d1 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -22,7 +22,7 @@ jobs: - run: echo $GITHUB_REPOSITORY_OWNER_PART - name: Cancel this build uses: andymckay/cancel-action@0.2 - if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART != "OpenFactorioServerManager" + if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART != 'OpenFactorioServerManager' test-npm: needs: [ check-double-run ] strategy: From 137844a8a174b48caa6a81ae2fab09fb7ae752da Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:13:07 +0100 Subject: [PATCH 04/15] fix wrong syntax v3 --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index c74f06d1..1b9cb820 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -22,7 +22,7 @@ jobs: - run: echo $GITHUB_REPOSITORY_OWNER_PART - name: Cancel this build uses: andymckay/cancel-action@0.2 - if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART != 'OpenFactorioServerManager' + if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART == 'OpenFactorioServerManager' test-npm: needs: [ check-double-run ] strategy: From 0cabd19664de21280414fcfb17297440ece73290 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:37:49 +0100 Subject: [PATCH 05/15] give access token to the github token --- .github/workflows/test-workflow.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 1b9cb820..fdff53e6 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -22,6 +22,8 @@ jobs: - run: echo $GITHUB_REPOSITORY_OWNER_PART - name: Cancel this build uses: andymckay/cancel-action@0.2 + with: + token: ${{ github.token }} if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART == 'OpenFactorioServerManager' test-npm: needs: [ check-double-run ] From 5b09f93b8158e948f9d26f92d34f9720c7c7347a Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:43:29 +0100 Subject: [PATCH 06/15] use secret env instead github env --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index fdff53e6..6b84af75 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -23,7 +23,7 @@ jobs: - name: Cancel this build uses: andymckay/cancel-action@0.2 with: - token: ${{ github.token }} + token: ${{ secrets.GITHUB_TOKEN }} if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART == 'OpenFactorioServerManager' test-npm: needs: [ check-double-run ] From 5d6e3751448ab01dd66130c63d266b11e3e491f1 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Fri, 29 Jan 2021 04:58:20 +0100 Subject: [PATCH 07/15] use my fork for cancel action --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 6b84af75..daf46bc9 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -21,7 +21,7 @@ jobs: - uses: rlespinasse/github-slug-action@v3.x - run: echo $GITHUB_REPOSITORY_OWNER_PART - name: Cancel this build - uses: andymckay/cancel-action@0.2 + uses: knoxfighter/cancel-action@master with: token: ${{ secrets.GITHUB_TOKEN }} if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART == 'OpenFactorioServerManager' From d8b323f21d4f7cca0dc6b3f566625afb8bc9a626 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:20:27 +0100 Subject: [PATCH 08/15] change testoutput to GITHUB_BASE_REF --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index daf46bc9..e51f00a0 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo $GITHUB_REPOSITORY_OWNER_PART + - run: echo $GITHUB_BASE_REF - name: Cancel this build uses: knoxfighter/cancel-action@master with: From b097e31087878a411c5827bef8ba615535cfdf47 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:32:20 +0100 Subject: [PATCH 09/15] use `pull_request_target` --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index e51f00a0..60beff54 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -4,7 +4,7 @@ on: - '**' tags-ignore: - '*.*' - pull_request: + pull_request_target: branches: - '**' env: From bd09cedd34ed45fda1d296a7205db61626f1f31b Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:34:01 +0100 Subject: [PATCH 10/15] revert "use `pull_request_target`" --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 60beff54..e51f00a0 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -4,7 +4,7 @@ on: - '**' tags-ignore: - '*.*' - pull_request_target: + pull_request: branches: - '**' env: From 1f63338e9eaa594a85253875d17f62fe3abd9c9a Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:42:25 +0100 Subject: [PATCH 11/15] change testoutput --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index e51f00a0..30eeeb83 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo $GITHUB_BASE_REF + - run: echo ${{ github.repository }} - name: Cancel this build uses: knoxfighter/cancel-action@master with: From e5f9b9b50bdf46534b48c4f42af90c39a3caf0cd Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:54:28 +0100 Subject: [PATCH 12/15] change testoutput --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 30eeeb83..292bb5ba 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo ${{ github.repository }} + - run: echo ${{ github.context }} - name: Cancel this build uses: knoxfighter/cancel-action@master with: From c18011f7532cb59fa34506640599bf5829ae0441 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:55:45 +0100 Subject: [PATCH 13/15] change testoutput --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 292bb5ba..94555a45 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo ${{ github.context }} + - run: echo "${{ github.context.ref }} -- ${{ github.context.sha }}" - name: Cancel this build uses: knoxfighter/cancel-action@master with: From bd54f079b5301598e7dc5846ac9542c10743b1b5 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 02:58:20 +0100 Subject: [PATCH 14/15] change testoutput --- .github/workflows/test-workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 94555a45..86959380 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,7 +19,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo "${{ github.context.ref }} -- ${{ github.context.sha }}" + - run: echo "${{ github.ref }} -- ${{ github.sha }}" - name: Cancel this build uses: knoxfighter/cancel-action@master with: From a6898bd8e183c655b176865e77338f8275cf4b80 Mon Sep 17 00:00:00 2001 From: knoxfighter Date: Sat, 30 Jan 2021 04:40:34 +0100 Subject: [PATCH 15/15] use my new created action to check action already run --- .github/workflows/test-workflow.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml index 86959380..3d1179c0 100644 --- a/.github/workflows/test-workflow.yml +++ b/.github/workflows/test-workflow.yml @@ -19,12 +19,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: rlespinasse/github-slug-action@v3.x - - run: echo "${{ github.ref }} -- ${{ github.sha }}" - name: Cancel this build - uses: knoxfighter/cancel-action@master + uses: knoxfighter/cancel-multi-action@main with: token: ${{ secrets.GITHUB_TOKEN }} - if: github.event_name == 'pull_request' && env.GITHUB_REPOSITORY_OWNER_PART == 'OpenFactorioServerManager' + if: github.event_name == 'pull_request' test-npm: needs: [ check-double-run ] strategy: