Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React hooks for admin CSV pages #887

Closed
huss opened this issue Apr 19, 2023 · 1 comment
Closed

React hooks for admin CSV pages #887

huss opened this issue Apr 19, 2023 · 1 comment
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 19, 2023

Is your feature request related to a problem? Please describe.

Please see issue #726 for information.

Describe the solution you'd like

The CSV page located in files src/client/app/components/csv/MetersCSVUploadComponent.tsx, src/client/app/components/csv/ReadingsCSVUploadComponent.tsx & src/client/app/containers/csv/UploadCSVContainer.tsx need to be updated for React hooks. The look of the page will stay the same.

Note that each entry item has its own function to deal with changes. The conversions, groups, meters and units pages now have combined functions that can handle input by its type (edit groups sets more complex state). These ideas should be brought into these pages to reduce the number of functions. There is also a way to deal with enum that use a map instead of listing each one that should also be used.

Additional context

None

@huss huss added the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Apr 19, 2023
@huss huss added this to the 1.1 release milestone Apr 19, 2023
@huss huss mentioned this issue May 9, 2023
10 tasks
@huss huss removed the reserved Expected to be assigned to developer by project so others should not work on without prior approval. label Sep 26, 2023
@huss
Copy link
Member Author

huss commented Apr 4, 2024

Superseded by issue #1198 so closing.

@huss huss closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant