Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow Redux styles suggestions #1179

Open
huss opened this issue Apr 1, 2024 · 1 comment
Open

follow Redux styles suggestions #1179

huss opened this issue Apr 1, 2024 · 1 comment
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Milestone

Comments

@huss
Copy link
Member

huss commented Apr 1, 2024

Is your feature request related to a problem? Please describe.

Redux has a number of recommended styles including:

It is unclear that OED is doing these or doing them consistently.

Describe the solution you'd like

With the transition to Redux Toolkit, OED will follow their recommendations for style. This makes it easier for a developer to map from Redux help/tutorials/documentation to OED's code base. It also should be easier for anyone familiar with standard Redux style.

Describe alternatives you've considered

What OED has will work but continue to have added overhead for developers.

Additional context

None

@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. labels Apr 1, 2024
@huss huss added this to the 1.x milestone Apr 1, 2024
@huss huss moved this to Todo in Redux Toolkit Apr 1, 2024
@huss
Copy link
Member Author

huss commented May 31, 2024

I think this should wait until OED completely most/all of the Redux Toolkit conversion. This should mean few new files are being created/changed during the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Projects
Status: Todo
Development

No branches or pull requests

1 participant