Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled RTK dev-mode checks #1146

Open
ChrisMart21 opened this issue Mar 7, 2024 · 1 comment · May be fixed by #1314
Open

Disabled RTK dev-mode checks #1146

ChrisMart21 opened this issue Mar 7, 2024 · 1 comment · May be fixed by #1314
Labels
i-long-term This is a long-term issue that will probably require multiple pull requests and some design effort. p-high-priority This issue should be the focus of design and developement effort. t-enhancement This issues tracks a potential improvement to the software
Milestone
2.0 release

Comments

@ChrisMart21
Copy link
Contributor

ChrisMart21 commented Mar 7, 2024 •
edited
Loading

Describe the issue:
In order to prevent the app fro malfunctioning, serializableCheck, and immutableCheck have to be disabled.

To Reproduce
Steps to reproduce the behavior(s):

  • re-enable immutability checks in store.ts by commenting out the immutableCheck: false
  • re-enable serializable checks in store.ts by commenting out the serializableCheck: false
    inspect browser console.logs for errors .
  • Time Interval is a non-serializable class object, and is used heavily in graphSlice/elsewhere
  • maps reducers seem to be mutating state.

Expected behavior
The app should encounter no such issues, and be able to safely enable ALL devmode checks, and be using newer RTK patterns.
@ChrisMart21 ChrisMart21 converted this from a draft issue Mar 7, 2024
@ChrisMart21 ChrisMart21 added i-long-term This is a long-term issue that will probably require multiple pull requests and some design effort. p-high-priority This issue should be the focus of design and developement effort. labels Mar 7, 2024
This was referenced Mar 7, 2024
Open
Open
@ChrisMart21 ChrisMart21 added the t-enhancement This issues tracks a potential improvement to the software label Mar 7, 2024
@huss huss added this to the 1.1 release milestone Mar 23, 2024
@huss
Copy link
Member

huss commented Apr 3, 2024

There was a note from the RTK conversion that EditMeterModal had an issue with React Strict Mode Warning about props.
If this is the case then there may be others. This seems to relate to this issue so putting it here.

@ChrisMart21 ChrisMart21 linked a pull request Aug 13, 2024 that will close this issue
Open
5 tasks
@ChrisMart21 ChrisMart21 linked a pull request Aug 13, 2024 that will close this issue
Maps Update: Cards and Modals for Maps Components #1314
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i-long-term This is a long-term issue that will probably require multiple pull requests and some design effort. p-high-priority This issue should be the focus of design and developement effort. t-enhancement This issues tracks a potential improvement to the software
Projects
Redux Toolkit
Status: Todo
Milestone
2.0 release
Development

Successfully merging a pull request may close this issue.

Maps Update: Cards and Modals for Maps Components juanjoseguva/OEDCST489Fork
2 participants
@huss @ChrisMart21