Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e test issues on Windows: stderr buffer too small #51

Open
pavel-kirienko opened this issue Apr 25, 2022 · 0 comments
Open

e2e test issues on Windows: stderr buffer too small #51

pavel-kirienko opened this issue Apr 25, 2022 · 0 comments

Comments

@pavel-kirienko
Copy link
Member

On Windows, when the integration test suite runs a process with -v or -vv, it may get blocked at an arbitrary location waiting for the parent to read its stderr. This results in non-obvious timeout errors and it may cost one hours of debugging on Windows while it works on other platforms (don't ask how I know).

The pipes are currently configured to be unbuffered because otherwise, Windows discards the output when the child process is interrupted instead of flushing the streams properly.

Perhaps the child runner should start background tasks/threads to read from the pipes so that the child process is never blocked. The runner is defined in tests/subprocess.py:

class Subprocess:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant