Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCMISSLocalConfig doesn't differentiate between Debug and Release build types #110

Open
chrispbradley opened this issue Jun 27, 2021 · 3 comments

Comments

@chrispbradley
Copy link
Member

The OpenCMISSLocalConfig.cmake file is stored in an archpath under manage. However, it is stored outside the final build type directory in the archpath. This means that different build types can not have different configs. I need different configs for, say, Debug and Release build types in order to turn on/off various debug, profiling and testing features. Options to fix this are

  1. Move OpenCMISSLocalConfig.cmake into the build type directory (preferred as it will keep everything together) or
  2. Have an additional local config file in the build type directory that is read as well (not preferred as it may harder for somebody to configure as they have to do things in two different places).
    In addition to the above the first release directory under manage is redundant.
@hsorby
Copy link
Contributor

hsorby commented Jun 28, 2021

The OpenCMISSLocalConfig doesn't differentiate between Debug and Release because they are not fully fledged configuration parameters like MPI is for example. Depending on how you define the profiling and testing features they may also not be fully fledged configuration options. The OpenCMISSLocalConfig is only for fully fledged configuration options and therefore shouldn't be moved into a build type sub-directory.

@hsorby
Copy link
Contributor

hsorby commented Jun 28, 2021

The first release directory under manage may well be redundant but it is consistent.

@chrispbradley
Copy link
Member Author

Debug and Release etc. might not be fully fledged configuration parameters for you but they are for me. The options change what code compiles, what libraries are linked and are completely consistent with the other options in the OpenCMISSLocalConfig.cmake file. If the fully fledged configuration options are required to be differentiated with the build type then there is no reason why the config file cannot sit under the build type directory in the archpath. I'm glad you agree that the first release under manage is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants