-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn user if tick import errors #913
Comments
i can probably take this. i added a in addition, i think this would be a good opportunity to transition the popup box from |
@clintonlunn Thanks. Longer term I think we can let users provide their MP and/or theCrag profile URL in their profile settings once. They can then initiate a re-import any time wish without having to provide a profile URL each time. |
@vnugent I think that's a great suggestion. Do you have ideas of how/where we can store the mp/crag url? |
…component and references in apps #913
We can store it in our DB. The profile update endpoint will need an update. |
I'd be up for completing that work, just not very certain on where to start. But that can be an issue that gets created after this is closed. |
We can introduce the profile settings in a separate PR. After this one is merged, I'd like to get PR #970 in (touching lots of files) so that contributors don't have to deal with merge conflicts. |
* feat: add progress and error indicator for importing mountainproject ticks #913 * feat: update importfrommtnproj component and add some basic tests #913 * feat: center spinner, better error handling on fetches #913 * feat: refactor component, remove unused isButton prop and logic from component and references in apps #913 * feat: disable button when loading #913
Sometimes tick import has an error (e.g. due to #631 ). It is not obvious when this happens - I have been unsure whether I missed the success notification, it is still processing, or it failed.
Make it obvious. Briefly say what happened (maybe just say which tick failed). Dev builds could give more details.
Related: #891
How important is this to you (Please pick one)
The text was updated successfully, but these errors were encountered: