You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
it's not possible to instead configure these cibuildwheel options in a pyproject.toml file, because not setting these inptus sets the environment variables to empty strings, which overrides pyproject.toml configuration.
Possible solutions:
Only set these environment variables if the inputs are given to the action
Remove these variables, and instead tell users to use pyproject.toml to configure cibuildwheel. This would be breaking, but I think with a major version bump of the action fine.
The text was updated successfully, but these errors were encountered:
Similar to #77. I think the first option should be possible. The environment variables can be conditionally set in a new workflow job step just before the cibuildwheel step.
Picking up on #127 (comment) I wonder if we should make the sdist action be able to read its config from pyproject.toml then we wouldn't need these vars at all?
Because the publish workflow specifies the follwing environment variables:
github-actions-workflows/.github/workflows/publish.yml
Lines 167 to 168 in bb12d54
it's not possible to instead configure these cibuildwheel options in a
pyproject.toml
file, because not setting these inptus sets the environment variables to empty strings, which overridespyproject.toml
configuration.Possible solutions:
pyproject.toml
to configure cibuildwheel. This would be breaking, but I think with a major version bump of the action fine.The text was updated successfully, but these errors were encountered: