Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for config file #723

Closed
Virensk opened this issue Jan 16, 2025 · 4 comments
Closed

Documentation for config file #723

Virensk opened this issue Jan 16, 2025 · 4 comments

Comments

@Virensk
Copy link

Virensk commented Jan 16, 2025

Hello,

I see that the tool supports config files, and there is an example in the tests as well. However, it's not very clear what the different options are, and how to specify what's incompatible at what level of granularity and the like. Could you please share some documentation or more detailed examples on what these files should look like, for more advanced cases.

Thanks,
Viren

@DrSatyr
Copy link
Collaborator

DrSatyr commented Jan 24, 2025

Hello, based on the codebase this configuration file is coupled directly with BackwardIncompatibleProp enum. So basically this enum describes all possible properties and their default values. I suppose it can be a clue for you about what this conf file should consist of.

You can navigate through ENUM values usage, and determine the level of granularity for each of them. Of course, it is not convenient, but we have no other options at the moment.

@Virensk
Copy link
Author

Virensk commented Jan 24, 2025

Thanks for the reply. That makes sense, I was hoping it would be a bit more flexible than that, but if it's hardcoded into the checks, it seems like we have to use these as a base for backward incompatibility checking.

@Virensk Virensk closed this as completed Jan 24, 2025
@DrSatyr
Copy link
Collaborator

DrSatyr commented Jan 24, 2025

Yeah, in my project we relied only on diff capabilities from openapi-diff. logic related to detecting breaking changes, results rendering was added on our own on top of it.

@Virensk
Copy link
Author

Virensk commented Jan 24, 2025

That makes sense, thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants