Client connecting progress indicator

[GwnDaan]

Add loading indicator in UI that there is a VT client being connected. For really large pools, you think it's hanging, while in practice it is transferring the object pool(s).

[ad3154]

100% agreed but will be tricky... I think maybe the server should register for the EDPO message and calculate progress based on that plus the total byte count compared to the requested byte count in the Get Memory message? Will have to experiment...

[GwnDaan]

I think it's better to integrate it into the stack itself. Like a function to get the active transport protocol sessions between two control functions. And then there can simply be a getter to get the progress in fractions/percentages of the total number of bytes transferred. Though then we should consider waiting for Open-Agriculture/AgIsoStack-plus-plus#344 first, because otherwise we are duplicating our work...

I think this approach will result in a smoother progress bar than solely depending on EDPO (which can be every 255 frames, and can even reach up to 255*200ms = +/-25 seconds)

[GwnDaan]

A function to get progress percentage for transportation sessions will be added with Open-Agriculture/AgIsoStack-plus-plus#391

[ad3154]

Now that your ETP/TP changes are merged, I might be able to knock this out this weekend. I am thinking of drawing a circular progress bar where each working set icon would be drawn once it's fully transferred.

[martonmiklos]

Hi folks,

I started to work on this, actually got it even rolling.:

Any comments on the visuals?
I have less than zero sense for design, any comment is welcome.

[ad3154]

I was also thinking we'd go down the path of drawing the indicator where the working set icon would be, so that's consistent with the direction I had in my head at least.

My initial thought was to use a Juce progress bar with the "arched" style for it, but a percent gives more useful info.
Are you using the regular juce progress bar here?

[ad3154]

Actually, the JUCE progress bars can include a percentage, so it might be a bit cleaner to just use that - maybe at least take a look and consider

[martonmiklos]

Actually, the JUCE progress bars can include a percentage, so it might be a bit cleaner to just use that - maybe at least take a look and consider

Well so far I did it in a stone aged approach: using a rectangle and a text, but I will take a look on Juce's progressbar.

[martonmiklos]

Juce's API approach is quite strange for this use case: we need to pass a reference to a variable to update the drawing.

I tried to workaround it in by calling setTextToDisplay in a custom paint event, but the text's % part is not displayed:
I also tried to use the linear style but I still got this pie like display:

Anyway Muller's but IOP and TP size highlighted me that it is not enough to update it at the chunks, but I will need to somehow smuggle the TransportProtocolSessionBase::get_percentage_bytes_transferred to the progress reporting.