Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check uri_to_id #4

Closed
koenedaele opened this issue Sep 25, 2014 · 1 comment
Closed

Check uri_to_id #4

koenedaele opened this issue Sep 25, 2014 · 1 comment
Assignees
@dieuska
Labels
question
Milestone
0.1.0

Comments

@koenedaele
Copy link
Member

Seems very specific for a certain set of uri's. Consider renaming it to concept_uri_to_id. Might also be better fitted as a private method on the HeritagedataProvider.
@koenedaele koenedaele added this to the 0.1.0 milestone Sep 25, 2014
@dieuska
Copy link
Contributor

dieuska commented Sep 30, 2014

renamed it to a private general method _split_uri because it is also used to extract the base_uri and the uri_id in this specific skosprovider

@dieuska dieuska closed this as completed Sep 30, 2014
dieuska added a commit that referenced this issue Sep 30, 2014
@dieuska
fixes #4 #5
739a148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dieuska dieuska

Labels
question
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
2 participants
@koenedaele @dieuska