From f5d1e2775b7b7f9a508d9c9efab429f5c7ec5be1 Mon Sep 17 00:00:00 2001 From: Jenna Antilla <46546946+jennantilla@users.noreply.github.com> Date: Mon, 4 Dec 2023 20:10:49 -0800 Subject: [PATCH] remove try/catch block from getTags The try/catch block is unnecessary since creating a new JSONObject from a Map will not throw a JSONException. --- .../onesignal/rnonesignalandroid/RNOneSignal.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java b/android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java index 7a922f8a..36713cc4 100644 --- a/android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java +++ b/android/src/main/java/com/onesignal/rnonesignalandroid/RNOneSignal.java @@ -577,16 +577,12 @@ public void removeTags(ReadableArray tagKeys) { @ReactMethod public void getTags(Promise promise) { - try { - Map tags = OneSignal.getUser().getTags(); - WritableMap writableTags = Arguments.createMap(); - for (Map.Entry entry : tags.entrySet()) { - writableTags.putString(entry.getKey(), entry.getValue()); - } - promise.resolve(writableTags); - } catch (Throwable t) { - promise.reject(t.getMessage()); + Map tags = OneSignal.getUser().getTags(); + WritableMap writableTags = Arguments.createMap(); + for (Map.Entry entry : tags.entrySet()) { + writableTags.putString(entry.getKey(), entry.getValue()); } + promise.resolve(writableTags); } @ReactMethod