Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](issue#42) Augmented Type Declaration Fix #44

Closed

Conversation

cepicdalim
Copy link

@cepicdalim cepicdalim commented Oct 4, 2024

Defination
Onesignal global type breaks other global types #42

Example Error

TSC gives error due to augmentation is on @vue/runtime-core
"[TYPE]" does not exist on type 'CreateComponentPublicInstanceWithMixins<ToResolvedProps<{}, {}>

Reproducing
You can take a look at #42 for more details.

What is changed?
"@vue/runtime-core" augmentation changed to "vue" due to vue documentation

@cepicdalim cepicdalim changed the title [fix][#42] Global Type Declaration Issue [fix](issue#42) Global Type Declaration Issue Oct 4, 2024
@cepicdalim cepicdalim changed the title [fix](issue#42) Global Type Declaration Issue [fix](issue#42) Global Type Declaration Bugfix Oct 4, 2024
@cepicdalim cepicdalim changed the title [fix](issue#42) Global Type Declaration Bugfix [fix](issue#42) Augmented Type Declaration Fix Oct 4, 2024
@gomorizsolt
Copy link

gomorizsolt commented Jan 10, 2025

@rgomezp @jkasten2 hey guys, could you pls help move forward with this pull request?

the type errors in templates are bugging me for a while 😄

@rgomezp
Copy link
Contributor

rgomezp commented Jan 10, 2025

Thanks for opening this pull request, however PRs here won't be merged since this package is code-generated.

The change needs to be made here -- though this needs to be tested to ensure it's not a breaking change.

Considerations:

  • module reference shift
  • do downstream projects need to update their code?
  • do we need to document this change?
  • should we deprecate the old declaration before removing it?
  • does vue2 face a similar issue?

cc @sherwinski

@rgomezp rgomezp closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants