Fix xcode 14 warnings and build failure #1132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
fixes #1113
This PR makes fixes related to using Xcode 14.
Details
The two fixes in this pr are
For this fix we will remove the armv7s archicture from builds
Running locationServicesEnabled on the main thread causes an Xcode warning in Xcode 14 about a potential UI holdup.
However the location manager class needs to be created and run on a thread with a runloop or it's updates won't come
through. To handle this we will do locationServicesEnabled on a background thread and location fetch on main thread
Motivation
Xcode 14 warnings
Scope
build architecture and location services
Testing
Unit testing
Updated location unit tests to account for async location fetch
Manual testing
tested location services on a physical iOS device
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is