From 9a309697e30ab2c93a4950e5dc021176f03f39be Mon Sep 17 00:00:00 2001
From: Nan <nanftw@gmail.com>
Date: Wed, 3 Jan 2024 15:07:06 -0800
Subject: [PATCH] Add `OneSignal-Subscription-Id` to all Update User requests

- Previously, we added the `OneSignal-Subscription-Id` header to update user requests that had `deltas` in the body.
- Now, we will add this header to all update user requests. This endpoint may have expected this all along, but this was a recent ask of the SDK.
---
 .../Requests/OSRequestUpdateProperties.swift  | 22 +++++++------------
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/iOS_SDK/OneSignalSDK/OneSignalUser/Source/Requests/OSRequestUpdateProperties.swift b/iOS_SDK/OneSignalSDK/OneSignalUser/Source/Requests/OSRequestUpdateProperties.swift
index 50dd02b1f..7a7bdbea3 100644
--- a/iOS_SDK/OneSignalSDK/OneSignalUser/Source/Requests/OSRequestUpdateProperties.swift
+++ b/iOS_SDK/OneSignalSDK/OneSignalUser/Source/Requests/OSRequestUpdateProperties.swift
@@ -44,7 +44,7 @@ class OSRequestUpdateProperties: OneSignalRequest, OSUserRequest {
     func prepareForExecution() -> Bool {
         if let onesignalId = identityModel.onesignalId,
             let appId = OneSignalConfigManager.getAppId(),
-           addPushSubscriptionIdToAdditionalHeadersIfNeeded() {
+           addPushSubscriptionIdToAdditionalHeaders() {
             self.addJWTHeader(identityModel: identityModel)
             self.path = "apps/\(appId)/users/by/\(OS_ONESIGNAL_ID)/\(onesignalId)"
             return true
@@ -55,21 +55,15 @@ class OSRequestUpdateProperties: OneSignalRequest, OSUserRequest {
         }
     }
 
-    func addPushSubscriptionIdToAdditionalHeadersIfNeeded() -> Bool {
-        guard let parameters = self.parameters else {
+    func addPushSubscriptionIdToAdditionalHeaders() -> Bool {
+        if let pushSubscriptionId = OneSignalUserManagerImpl.sharedInstance.pushSubscriptionId {
+            var additionalHeaders = self.additionalHeaders ?? [String: String]()
+            additionalHeaders["OneSignal-Subscription-Id"] = pushSubscriptionId
+            self.additionalHeaders = additionalHeaders
             return true
+        } else {
+            return false
         }
-        if parameters["deltas"] != nil { // , !parameters["deltas"].isEmpty
-            if let pushSubscriptionId = OneSignalUserManagerImpl.sharedInstance.pushSubscriptionId {
-                var additionalHeaders = self.additionalHeaders ?? [String: String]()
-                additionalHeaders["OneSignal-Subscription-Id"] = pushSubscriptionId
-                self.additionalHeaders = additionalHeaders
-                return true
-            } else {
-                return false
-            }
-        }
-        return true
     }
 
     init(properties: [String: Any], deltas: [String: Any]?, refreshDeviceMetadata: Bool?, modelToUpdate: OSPropertiesModel, identityModel: OSIdentityModel) {