-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update native OneSignal SDKs dependencies to 5.1.x #689
Conversation
Unity devs must target API level 33 or higher because androidx.work:work-runtime-ktx:2.8.1 from the OneSignal Android SDK requires compileSdkVersion 33 or higher.
@shepherd-l Is there any reason that we update IOS to 5.1.0 instead of 5.1.1? |
@jinliu9508 I think 5.1.0 is the latest release of iOS. Could you show me where you found a 5.1.1 release? |
This sounds ok to me, since you must target Android 33 to release to the Play Store now, anyway. |
Yes you are correct, 5.1.1 IOS is only in draft mode. This looks good to me know. |
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
[Feature] Update native OneSignal SDKs dependencies to 5.1.x
Description
One Line Summary
Updated included OneSignal Android SDK to 5.1.1 and OneSignal iOS SDK to 5.1.0
Details
Motivation
Applies native fixes from the OneSignal Android SDK and OneSignal iOS SDK to the Unity SDK
Scope
Unity developers must target API level 33 or higher to build for Android. This is because androidx.work:work-runtime-ktx:2.8.1 from the OneSignal Android SDK requires compileSdkVersion 33 or higher.
Older versions of Unity do not include Android 33 by default - 2022 and below, so users will have to download it. Steps on how to do so are listed in the Unity docs: Setting the Android SDK Target API.
Testing
Manual testing
Tested OneSignal initialization, app build with Unity 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 15.5.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is