From b3997fe4f63f39438a6b78575fb5029beab6ec85 Mon Sep 17 00:00:00 2001 From: Shepherd Date: Tue, 19 Dec 2023 18:04:30 -0500 Subject: [PATCH 1/2] Remove ACCESS_COARSE_LOCATION permission Require developers to add ACCESS_COARSE_LOCATION to their AndroidManifest themselves. This is done to avoid the location permission requirement for those who use the com.onesignal:OneSignal package like our wrapper SDKs. This change reverts back to the player model behaviour --- OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml b/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml index 1c58b57653..d0cbe3586e 100644 --- a/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml +++ b/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml @@ -1,7 +1,6 @@ - + - \ No newline at end of file From 230980a7d66773f217a08732ef33f27bcd964ecd Mon Sep 17 00:00:00 2001 From: Shepherd Date: Wed, 27 Dec 2023 15:38:26 -0500 Subject: [PATCH 2/2] Update comment Make it clear that developers have to add the access location permission to their AndroidManifest for the location module to work --- OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml b/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml index d0cbe3586e..93ee433077 100644 --- a/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml +++ b/OneSignalSDK/onesignal/location/src/main/AndroidManifest.xml @@ -1,6 +1,6 @@ - + \ No newline at end of file