Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - is_imageslider has a problem with slide pagination #423

Open
Maofree opened this issue Sep 20, 2024 · 2 comments
Open

🐛 [BUG] - is_imageslider has a problem with slide pagination #423

Maofree opened this issue Sep 20, 2024 · 2 comments
Labels
bug Something isn't working is_imageslider

Comments

@Maofree
Copy link

Maofree commented Sep 20, 2024

Description

Hi
when there are more than 10 slides in the slide list, pages of 10 slides per page are created. If I select 20 slides per page, then the slides are no longer displayed in the list, so the list becomes empty. This is useful for changing the position of the slides, you can only do it on one page

bye

Node.js version

v18

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

is_imageslider 2.3.2

Reproduction steps

1. Go to is_imageslider
2. add 12 slides
3. change the pagination to see 20 slides for each page
4. no slide is shown in the list

Logs

No response

@Maofree Maofree added the bug Something isn't working label Sep 20, 2024
@Oksydan
Copy link
Owner

Oksydan commented Sep 20, 2024

Hi @Maofree

Actually I am aware of this problem. It has been fixed on the branch with module refacto https://github.com/Oksydan/is_imageslider/blob/module-refacto/views/templates/admin/index.html.twig#L44 for now you can apply this fix.
I am going to release patch version soon.

@Maofree
Copy link
Author

Maofree commented Sep 20, 2024

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working is_imageslider
Projects
None yet
Development

No branches or pull requests

2 participants