Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainquery / sdk naming discrepancies #88

Open
tzarebczan opened this issue Feb 1, 2019 · 1 comment
Open

chainquery / sdk naming discrepancies #88

tzarebczan opened this issue Feb 1, 2019 · 1 comment
Labels
type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@tzarebczan
Copy link
Contributor

tzarebczan commented Feb 1, 2019

  1. we store the sd_hash in a field called sd_hash - it should instead be called source, with the type coming from sourceType.

  2. missing claim sequence (there are some changes coming here with normalization I think)

  3. missing amount - the original claim amount - not the effective amount (which we have)

  4. missing supports - link to the supports table?

  5. missing license / license url / preview (@tiger5226 started working on this one already)

  6. publisher vs channel (i.e. publisher_id vs channel_id)

@tzarebczan tzarebczan added the type: improvement Existing (or partially existing) functionality needs to be changed label Feb 1, 2019
@tiger5226
Copy link
Collaborator

@tzarebczan feel free to update this issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

2 participants