Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put support_type into Support table #128

Open
melroy89 opened this issue Sep 9, 2019 · 2 comments
Open

Put support_type into Support table #128

melroy89 opened this issue Sep 9, 2019 · 2 comments
Labels
icebox Long-term storage

Comments

@melroy89
Copy link

melroy89 commented Sep 9, 2019

Hi,

Its very hard to figure out if a row in the support table is actually just 'support' or really a 'tip'. My proposal would be to introduce support_type (I don't care which database type it will be, could be an int or enum or ...).

As long as you can easily distinguish if the support is a tip or a support (or whatever LBRY could have in the future as well).

Regards,
Melroy van den Berg

@tzarebczan
Copy link
Contributor

There's really no clean way to tell right now except for looking at the claim address, which historically may be different and could potentially change (guess we can still track at time of tx). The blockchain team is working on introducing metadata for supports, so we can then mark them appropriately among other cool things we can start to utilize the metadata for (i.e comments, ratings, subscriptions, signed supports)

@tiger5226 tiger5226 added the icebox Long-term storage label Sep 11, 2019
@tiger5226
Copy link
Collaborator

Yeah, agreed with @tzarebczan here. There is no really accurate way to do this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox Long-term storage
Projects
None yet
Development

No branches or pull requests

3 participants