-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make codept
as a library (1/n)
#14
Comments
It is good idea, it is true that the Namespaced module has evolved to conflate namespaced path and non-empty paths. It probably a good idea to split back the two concepts. |
The issue is more difficult than I imagined. Currently. the type
It seems that these views can cohabit but it's hard to fix then a more restrictive definition of |
Maybe more |
Just to follow up a discussion with @Octachron, |
In my objective to be able to export a nice library to calculate dependencies from the
codept
project, several points need to be clarify to improve step by step the project - this is why there is a1/n
. Each of these points will be of interest in what I think is a good library and we can discuss the interest of each and see if it is worth spending time on it or not. So this is going to be a series of questions possibly associated with PRs.The first point I'd like to highlight is the exposure of the guys. From what I can see from the project, the use of modules often implies implicit knowledge about the use of certain types which only becomes clear through their use. A first step that would help clarify the interest of the modules (and then export them as a library) would be to:
The first modules in which there is surely a particular interest to abstract would be the
Name
,Path
andNamespaced
modules. For the last two modules - and I've noted this several times in the code - one could ensure that aPath
cannot beempty
(eg. an empty list). This would partially change theNamespaced
type, which would have an optional namespace (currently embodied as an empty list).What do you think about this change?
The text was updated successfully, but these errors were encountered: