Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more link breaks card labels #333

Open
kasya opened this issue Jan 2, 2025 · 2 comments · May be fixed by #343
Open

Show more link breaks card labels #333

kasya opened this issue Jan 2, 2025 · 2 comments · May be fixed by #343
Assignees
@Naveen-Pal
Labels
frontend

Comments

@kasya
Copy link
Collaborator

kasya commented Jan 2, 2025

Describe the bug
When we are on the Contribute page the card should show Show more when there are more labels available.
We have 2 types of labels - for languages and for topics. We should only show one Show more link if any of those have more items to show, but we should not show it after each type.
Example (first card). Also, clicking Show more doesn't really do anything in this case.

Expected behavior
We should only show Show more after all the labels if any of those have anything extra to show.

Screenshots
Screenshot 2025-01-02 at 10 18 49 AM
@github-project-automation github-project-automation bot moved this to Backlog in Project Nest Jan 2, 2025
@kasya kasya added the frontend label Jan 2, 2025
@Naveen-Pal
Copy link
Collaborator

Hi @kasya .
I am interested to work on it.

@kasya
Copy link
Collaborator Author

kasya commented Jan 2, 2025

Thanks @Naveen-Pal! This one's yours now 👌🏼

@Naveen-Pal Naveen-Pal linked a pull request Jan 5, 2025 that will close this issue
Open
@arkid15r arkid15r moved this from Backlog to In progress in Project Nest Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Naveen-Pal Naveen-Pal

Labels
frontend
Projects
Project Nest
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed show more link breaks card labels Naveen-Pal/Nest
2 participants
@kasya @Naveen-Pal