Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.05.04 final release fixes #2893

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

opcfoundation-org
Copy link
Contributor

Proposed changes

Merges the changes needed for the 1.05.04 release.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 52.46914% with 231 lines in your changes missing coverage. Please review.

Project coverage is 55.44%. Comparing base (cf82847) to head (a4fd432).

Files with missing lines Patch % Lines
Stack/Opc.Ua.Core/Types/Encoders/JsonEncoder.cs 52.43% 149 Missing and 17 partials ⚠️
.../Opc.Ua.Core/Types/Constants/Attributes.Helpers.cs 0.00% 27 Missing ⚠️
Stack/Opc.Ua.Core/Types/Encoders/JsonDecoder.cs 9.52% 15 Missing and 4 partials ⚠️
Stack/Opc.Ua.Core/Types/Utils/TypeInfo.cs 0.00% 2 Missing and 2 partials ⚠️
...c.Ua.Client.ComplexTypes/Types/UnionComplexType.cs 85.71% 2 Missing and 1 partial ⚠️
Stack/Opc.Ua.Core/Schema/UANodeSet.cs 50.00% 3 Missing ⚠️
Stack/Opc.Ua.Core/Types/BuiltIn/ExtensionObject.cs 0.00% 1 Missing and 1 partial ⚠️
...ck/Opc.Ua.Core/Types/Encoders/EncodeableFactory.cs 0.00% 2 Missing ⚠️
...es/Opc.Ua.Client.ComplexTypes/ComplexTypeSystem.cs 0.00% 1 Missing ⚠️
...es/Opc.Ua.PubSub/Transport/MqttPubSubConnection.cs 88.88% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2893      +/-   ##
==========================================
- Coverage   55.50%   55.44%   -0.07%     
==========================================
  Files         352      352              
  Lines       67851    68116     +265     
  Branches    13904    14007     +103     
==========================================
+ Hits        37664    37767     +103     
- Misses      26072    26189     +117     
- Partials     4115     4160      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen requested a review from marcschier December 17, 2024 06:16
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, ready to merge?

@mregen mregen added this to the 1.5.374 January update milestone Jan 7, 2025
randy-armstrong and others added 6 commits January 7, 2025 20:24
* Some cleanup of the new APIs and Union implementation.

* fix build

* Handle status code Uncertain according to the specification (#2898)

* #2896: Write output arguments for good and uncertain status code

When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification.

* #2896: The service result corresponds the method call result

The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior.

* Add SetHiResClockDisabled  & fix Rejected Store Creation in ApplicationConfigurationBuilder (#2909)

Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder
Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier

* revert based on feedback

* move some logic from class code to encoder/decoder

* Fix race condition on Nuget build (#2930)

- nodeset xmlzip is created in obj folders if multiple targets are built in parallel
@CLAassistant
Copy link

CLAassistant commented Feb 2, 2025

CLA assistant check
All committers have signed the CLA.

@romanett romanett changed the base branch from develop/main374 to master February 2, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants