-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made out place SIA2D compatibile with AD #48
Conversation
Hi @vivekag7, thanks for the PR! I see the tests are failing, there seems to be an issue with the conda environment and Pandas. @facusapienza21 I think you could be of help here. Do you have an idea why this could be failing? PyError ($(Expr(:escape, :(ccall(#= /home/runner/.julia/packages/PyCall/1gn3u/src/pyfncall.jl:43 =# @pysym(:PyObject_Call), PyPtr, (PyPtr, PyPtr, PyPtr), o, pyargsptr, kw))))) <class 'ImportError'>
ImportError("Pandas requires version '3.8.0' or newer of 'tables' (version '3.7.0' currently installed).") I'm afraid it's not something specific from this PR, more due to some changes in Python packages that are messing up our environment. |
🔄 synced file(s) with ODINN-SciML/Sleipnir.jl (ODINN-SciML#49)
Once you review the PR in Sleipnir I'll integrate it, make a new release and then we can re-run the tests here. |
Overview/Summary
List of Changes
H
fromV
, expanding the analytical capabilities of the model.Testing
-Very small fixes to the tests were necessary for compatibility
Additional Notes
When defining fields in a struct, using Matrix{<:Real} instead of a more restrictive type parameter like SIA2Dmodel{F <: AbstractFloat, I <: Integer} is crucial for ensuring compatibility with dual numbers, that why that is done.