From dbfdcd8217bed3ec74d6c0e4db3e8064605a01df Mon Sep 17 00:00:00 2001 From: Maksim Shurupov Date: Mon, 20 Jan 2025 14:34:28 +0300 Subject: [PATCH] [FIX] purchase_duplicate_check: Code review fixing --- purchase_duplicate_check/__manifest__.py | 3 --- purchase_duplicate_check/models/purchase_order.py | 4 +--- purchase_duplicate_check/tests/test_purchase_order.py | 3 +-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/purchase_duplicate_check/__manifest__.py b/purchase_duplicate_check/__manifest__.py index 3365c98cd8e..4fe330a8faa 100644 --- a/purchase_duplicate_check/__manifest__.py +++ b/purchase_duplicate_check/__manifest__.py @@ -7,15 +7,12 @@ "license": "AGPL-3", "category": "Inventory/Purchase", "website": "https://github.com/OCA/purchase-workflow", - "live_test_url": "https://demo.cetmix.com", "depends": ["purchase_stock", "confirmation_wizard"], - "external_dependencies": {}, "data": [ "views/purchase_order_views.xml", "views/res_config_settings_views.xml", "wizard/confirmation_wizard_views.xml", ], - "assets": {}, "installable": True, "application": False, } diff --git a/purchase_duplicate_check/models/purchase_order.py b/purchase_duplicate_check/models/purchase_order.py index 9c173d49c74..623a9ba9454 100644 --- a/purchase_duplicate_check/models/purchase_order.py +++ b/purchase_duplicate_check/models/purchase_order.py @@ -12,9 +12,7 @@ def _prepare_pending_orders_message(self, product_id): :return str: message """ message_parts = [] - order_lines = self.env["purchase.order.line"].search( - [("product_id", "=", product_id), ("order_id", "in", self.ids)] - ) + order_lines = self.order_line.filtered(lambda l: l.product_id.id == product_id) for line in order_lines: order = line.order_id order_href = ( diff --git a/purchase_duplicate_check/tests/test_purchase_order.py b/purchase_duplicate_check/tests/test_purchase_order.py index 59d4c67e18c..3f108c9038d 100644 --- a/purchase_duplicate_check/tests/test_purchase_order.py +++ b/purchase_duplicate_check/tests/test_purchase_order.py @@ -1,4 +1,3 @@ -from odoo.fields import Date from odoo.tests import Form, TransactionCase @@ -43,7 +42,7 @@ def test_prepare_pending_orders_message(self): """Test flow where prepare message for purchase order""" message = self.order1._prepare_pending_orders_message(self.product_2.id) self.assertFalse(message, "Message must be empty") - expected_message = f"RFQ: {self.order1.name} date: {Date.today()} Qty: 10.0
" # noqa + expected_message = f"RFQ: {self.order1.name} date: {self.order1.create_date.date()} Qty: 10.0
" # noqa message = self.order1._prepare_pending_orders_message(self.product_1.id) self.assertEqual(message, expected_message, "Messages must be the same")