Skip to content
This repository has been archived by the owner on Jul 25, 2018. It is now read-only.

500 error if no matching <chart_type> #3

Open
tym-xqo opened this issue Feb 28, 2018 · 0 comments
Open

500 error if no matching <chart_type> #3

tym-xqo opened this issue Feb 28, 2018 · 0 comments

Comments

@tym-xqo
Copy link
Contributor

tym-xqo commented Feb 28, 2018

If a request URL specifies a <chart_type> value that doesn't match a provisioned chart, the app hits a KeyError exception trying chart = charts[chart_type] and barfs out a generic 500 message.

Consistency with Nerium would suggest that we should fall back to a default chart_type if no match is found. Another option might be to return some sort of "chart type not found" message.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant