From 60c5ba1157163bb9afa861ba0c8c33ac1539cf7d Mon Sep 17 00:00:00 2001
From: Goz3rr <goz3rr@gmail.com>
Date: Sat, 30 Mar 2019 23:24:13 +0100
Subject: [PATCH] Add ByteProperty unit tests

---
 .../PropertyTypes/BytePropertyTests.cs        | 100 ++++++++++++++++++
 .../PropertyTypes/ByteProperty.cs             |   3 +-
 2 files changed, 102 insertions(+), 1 deletion(-)
 create mode 100644 SatisfactorySaveParser.Tests/PropertyTypes/BytePropertyTests.cs

diff --git a/SatisfactorySaveParser.Tests/PropertyTypes/BytePropertyTests.cs b/SatisfactorySaveParser.Tests/PropertyTypes/BytePropertyTests.cs
new file mode 100644
index 0000000..8c5e99b
--- /dev/null
+++ b/SatisfactorySaveParser.Tests/PropertyTypes/BytePropertyTests.cs
@@ -0,0 +1,100 @@
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using SatisfactorySaveParser.PropertyTypes;
+using System.IO;
+
+namespace SatisfactorySaveParser.Tests.PropertyTypes
+{
+    [TestClass]
+    public class BytePropertyTests
+    {
+        private static readonly string ByteEnumName = "mGamePhase";
+        private static readonly string ByteEnumType = "EGamePhase";
+        private static readonly string ByteEnumValue = "EGP_EndGame";
+        private static readonly byte[] ByteEnumBytes = new byte[] { 0x0B, 0x00, 0x00, 0x00, 0x6D, 0x47, 0x61, 0x6D, 0x65, 0x50, 0x68, 0x61, 0x73, 0x65, 0x00, 0x0D, 0x00, 0x00, 0x00, 0x42, 0x79, 0x74, 0x65, 0x50, 0x72, 0x6F, 0x70, 0x65, 0x72, 0x74, 0x79, 0x00, 0x10, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x0B, 0x00, 0x00, 0x00, 0x45, 0x47, 0x61, 0x6D, 0x65, 0x50, 0x68, 0x61, 0x73, 0x65, 0x00, 0x00, 0x0C, 0x00, 0x00, 0x00, 0x45, 0x47, 0x50, 0x5F, 0x45, 0x6E, 0x64, 0x47, 0x61, 0x6D, 0x65, 0x00 };
+
+        private static readonly string ByteNumberName = "mLastAutosaveId";
+        private static readonly byte ByteNumberValue = 0;
+        private static readonly byte[] ByteNumberBytes = new byte[] { 0x10, 0x00, 0x00, 0x00, 0x6D, 0x4C, 0x61, 0x73, 0x74, 0x41, 0x75, 0x74, 0x6F, 0x73, 0x61, 0x76, 0x65, 0x49, 0x64, 0x00, 0x0D, 0x00, 0x00, 0x00, 0x42, 0x79, 0x74, 0x65, 0x50, 0x72, 0x6F, 0x70, 0x65, 0x72, 0x74, 0x79, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x4E, 0x6F, 0x6E, 0x65, 0x00, 0x00, 0x00 };
+
+        [TestMethod]
+        public void BytePropertyEnumRead()
+        {
+            using (var stream = new MemoryStream(ByteEnumBytes))
+            using (var reader = new BinaryReader(stream))
+            {
+                var prop = SerializedProperty.Parse(reader) as ByteProperty;
+
+                Assert.AreNotEqual(null, prop);
+
+                Assert.AreEqual(ByteEnumName, prop.PropertyName);
+                Assert.AreEqual(ByteProperty.TypeName, prop.PropertyType);
+
+                Assert.AreEqual(0, prop.Index);
+
+                Assert.AreEqual(ByteEnumType, prop.Type);
+                Assert.AreEqual(ByteEnumValue, prop.Value);
+
+                Assert.AreEqual(stream.Length, stream.Position);
+            }
+        }
+
+        [TestMethod]
+        public void BytePropertyEnumWrite()
+        {
+            using (var stream = new MemoryStream())
+            using (var writer = new BinaryWriter(stream))
+            {
+                var prop = new ByteProperty(ByteEnumName)
+                {
+                    Type = ByteEnumType,
+                    Value = ByteEnumValue
+                };
+
+                prop.Serialize(writer);
+
+                Assert.AreEqual(16, prop.SerializedLength);
+                CollectionAssert.AreEqual(ByteEnumBytes, stream.ToArray());
+            }
+        }
+
+        [TestMethod]
+        public void BytePropertyNumberRead()
+        {
+            using (var stream = new MemoryStream(ByteNumberBytes))
+            using (var reader = new BinaryReader(stream))
+            {
+                var prop = SerializedProperty.Parse(reader) as ByteProperty;
+
+                Assert.AreNotEqual(null, prop);
+
+                Assert.AreEqual(ByteNumberName, prop.PropertyName);
+                Assert.AreEqual(ByteProperty.TypeName, prop.PropertyType);
+
+                Assert.AreEqual(0, prop.Index);
+
+                Assert.AreEqual(ByteNumberValue.ToString(), prop.Value);
+
+                Assert.AreEqual(stream.Length, stream.Position);
+            }
+        }
+
+        [TestMethod]
+        public void BytePropertyNumberWrite()
+        {
+            using (var stream = new MemoryStream())
+            using (var writer = new BinaryWriter(stream))
+            {
+                var prop = new ByteProperty(ByteNumberName)
+                {
+                    Type = "None",
+                    Value = "0"
+                };
+
+                prop.Serialize(writer);
+
+                Assert.AreEqual(1, prop.SerializedLength);
+                CollectionAssert.AreEqual(ByteNumberBytes, stream.ToArray());
+            }
+        }
+    }
+}
diff --git a/SatisfactorySaveParser/PropertyTypes/ByteProperty.cs b/SatisfactorySaveParser/PropertyTypes/ByteProperty.cs
index 64375f5..ce7e85b 100644
--- a/SatisfactorySaveParser/PropertyTypes/ByteProperty.cs
+++ b/SatisfactorySaveParser/PropertyTypes/ByteProperty.cs
@@ -23,7 +23,8 @@ public override string ToString()
 
         public override void Serialize(BinaryWriter writer, bool writeHeader = true)
         {
-            base.Serialize(writer, writeHeader);
+            if (writeHeader)
+                base.Serialize(writer, writeHeader);
 
             writer.Write(SerializedLength);
             writer.Write(Index);