Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate usage of inlined LDFLAGS #19

Open
dignifiedquire opened this issue Sep 27, 2023 · 3 comments
Open

Investigate usage of inlined LDFLAGS #19

dignifiedquire opened this issue Sep 27, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dignifiedquire
Copy link
Contributor

It is possible to include linking instructions in comments, it would be good to investigate if these could be pre-filled in some form, to avoid having to run go commands like this (from the test script)

LD_LIBRARY_PATH="${LD_LIBRARY_PATH:-}:$BINARIES_DIR" \
CGO_LDFLAGS="-luniffi_fixtures -L$BINARIES_DIR -lm -ldl" \
CGO_ENABLED=1 
@dignifiedquire
Copy link
Contributor Author

@arg0d any thoughts on this? would you be willing to accept a PR implementing this?

@arg0d
Copy link
Contributor

arg0d commented Nov 16, 2023

I guess so, but it should be optional. For our use case we need to link statically.

@Savolro your thoughts?

@arg0d
Copy link
Contributor

arg0d commented Nov 16, 2023

Actually, I guess it doesn't matter if linking static/dynamic libraries. The link args will be the same regardless if library is static/dynamic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants