Merge pull request #1128 from NordSecurity/test_disable_logs

Temporarily disable logs to see if dns tests stop failing
NordSecurity · Feb 19, 2025 · c0ac4d5 · c0ac4d5
2 parents 0c7b90f + 5e510fa
commit c0ac4d5
Show file tree

Hide file tree

Showing 9 changed files with 45 additions and 2 deletions.
diff --git a/.unreleased/test_disable_logs b/.unreleased/test_disable_logs
diff --git a/nat-lab/tests/test_direct_connection.py b/nat-lab/tests/test_direct_connection.py
@@ -255,6 +255,8 @@ async def ping_timeout(connection, node):
         await ping_between_all_nodes(env)
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.timeout(
@@ -421,6 +423,8 @@ async def test_direct_working_paths_stun_ipv6() -> None:
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.asyncio
 async def test_direct_working_paths_with_skip_unresponsive_peers() -> None:
     setup_params = _generate_setup_parameters([
@@ -533,6 +537,8 @@ async def test_direct_infinite_stun_loop() -> None:
         assert len(stun_requests) < 20
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.asyncio
 async def test_direct_working_paths_with_pausing_upnp_and_stun() -> None:
     setup_params = _generate_setup_parameters([

diff --git a/nat-lab/tests/test_dns.py b/nat-lab/tests/test_dns.py
@@ -1127,6 +1127,8 @@ def all_cases(name: str) -> List[str]:
     ]
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.asyncio
 async def test_dns_no_error_return_code() -> None:
     async with AsyncExitStack() as exit_stack:

diff --git a/nat-lab/tests/test_lana.py b/nat-lab/tests/test_lana.py
@@ -549,6 +549,8 @@ async def add_5ms_delay_to_connections(
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -727,6 +729,8 @@ async def test_lana_with_same_meshnet(
         assert res[0], res[1]
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -910,6 +914,8 @@ async def test_lana_with_external_node(
         assert alpha_events[0].fp != gamma_events[0].fp
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -1090,6 +1096,8 @@ async def test_lana_all_external(
         assert beta_events[0].fp != gamma_events[0].fp
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -1279,6 +1287,8 @@ async def test_lana_with_vpn_connection(
         assert res[0], res[1]
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -1512,6 +1522,8 @@ async def test_lana_with_meshnet_exit_node(
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -1913,6 +1925,8 @@ async def test_lana_with_disconnected_node(
         assert await beta_conn_tracker.find_conntracker_violations() is None
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -2016,6 +2030,8 @@ async def test_lana_with_second_node_joining_later_meshnet_id_can_change(
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("alpha_ip_stack,beta_ip_stack", IP_STACK_TEST_CONFIGS)
@@ -2095,6 +2111,8 @@ async def test_lana_same_meshnet_id_is_reported_after_a_restart(
         assert initial_beta_meshnet_id == second_beta_meshnet_id
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
@@ -2134,6 +2152,8 @@ async def test_lana_initial_heartbeat_no_trigger(
             )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("initial_heartbeat_interval", [pytest.param(5)])
@@ -2173,6 +2193,8 @@ async def test_lana_initial_heartbeat_count_since_meshnet_start(
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 @pytest.mark.parametrize("initial_heartbeat_interval", [pytest.param(5)])
@@ -2214,6 +2236,8 @@ async def test_lana_initial_heartbeat_count_since_meshnet_restart(
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.moose
 @pytest.mark.asyncio
 async def test_lana_rtt_interval_controls_periodic_qos_collection():

diff --git a/nat-lab/tests/test_network_monitor.py b/nat-lab/tests/test_network_monitor.py
@@ -8,6 +8,8 @@
 DEFAULT_WAITING_TIME = 2
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "alpha_setup_params",

diff --git a/nat-lab/tests/test_pinging.py b/nat-lab/tests/test_pinging.py
@@ -202,6 +202,8 @@ async def wait_for_conntracker() -> None:
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "alpha_setup_params",

diff --git a/nat-lab/tests/test_pq.py b/nat-lab/tests/test_pq.py
@@ -152,6 +152,8 @@ async def test_pq_vpn_connection(
         )
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.parametrize(
     "alpha_setup_params, public_ip",
     [
@@ -513,6 +515,8 @@ async def test_pq_vpn_upgrade_from_non_pq(
         assert preshared != EMPTY_PRESHARED_KEY_SLOT
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 # Regression test for LLT-5884
 @pytest.mark.timeout(240)
 @pytest.mark.parametrize(

diff --git a/nat-lab/tests/test_telio_tasks.py b/nat-lab/tests/test_telio_tasks.py
@@ -14,6 +14,8 @@
 from utils.connection_util import ConnectionTag
 
 
+# TODO(mathiaspeters): reenable
+@pytest.mark.skip
 @pytest.mark.asyncio
 async def test_telio_tasks_with_all_features() -> None:
     async with AsyncExitStack() as exit_stack:

diff --git a/nat-lab/tests/uniffi/libtelio_remote.py b/nat-lab/tests/uniffi/libtelio_remote.py
@@ -85,8 +85,9 @@ def __init__(self, daemon, logfile):
         self._libtelio = None
         self._event_cb = TelioEventCbImpl()
         self._logger_cb = TelioLoggerCbImpl(logfile)
-        libtelio.add_timestamps_to_logs()
-        libtelio.set_global_logger(libtelio.TelioLogLevel.DEBUG, self._logger_cb)
+        # TODO(mathiaspeters): reenable logs
+        # libtelio.add_timestamps_to_logs()
+        # libtelio.set_global_logger(libtelio.TelioLogLevel.DEBUG, self._logger_cb)
 
     def shutdown(self):
         if self._libtelio is not None: